python / cpython

The Python programming language
https://www.python.org
Other
63.19k stars 30.26k forks source link

[RFC] Remove leftover use of Carbon module from Lib/binhex.py #50870

Closed 8a20ad3a-3581-43a0-ab8d-b04a0598832e closed 15 years ago

8a20ad3a-3581-43a0-ab8d-b04a0598832e commented 15 years ago
BPO 6621
Nosy @mdickinson
Superseder
  • bpo-2715: Remove carbon-specific code from binhex
  • Files
  • py3k-binhex.py-remove-carbon-module-use.patch: remove carbon use in binhex module
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = created_at = labels = ['library'] title = '[RFC] Remove leftover use of Carbon module from Lib/binhex.py' updated_at = user = 'https://bugs.python.org/vincele' ``` bugs.python.org fields: ```python activity = actor = 'mark.dickinson' assignee = 'none' closed = True closed_date = closer = 'mark.dickinson' components = ['Library (Lib)'] creation = creator = 'vincele' dependencies = [] files = ['14623'] hgrepos = [] issue_num = 6621 keywords = ['patch'] message_count = 5.0 messages = ['91174', '91190', '91191', '91192', '91194'] nosy_count = 2.0 nosy_names = ['mark.dickinson', 'vincele'] pr_nums = [] priority = 'normal' resolution = 'duplicate' stage = None status = 'closed' superseder = '2715' type = None url = 'https://bugs.python.org/issue6621' versions = ['Python 3.1', 'Python 3.2'] ```

    8a20ad3a-3581-43a0-ab8d-b04a0598832e commented 15 years ago

    The binhex module still has uses of the deprecated and now now removed Carbon module.

    The attached patch 'fix' this by removing the code, something else may be required, but I don't know what.

    So this is only a RFC to start discussion

    mdickinson commented 15 years ago

    As far as I can tell, it looks safe to just remove these two blocks.
    There's a third block that should be removed as well (the second "if os.name == 'mac': ..." in the hexbin function.

    mdickinson commented 15 years ago

    This should be fixed in the 3.1 maintenance branch as well.

    mdickinson commented 15 years ago

    See also bpo-2715.

    mdickinson commented 15 years ago

    Closing as a duplicate of bpo-2715.