Closed ronaldoussoren closed 14 years ago
The attached patch removes all traces to os.name == 'mac' from the source tree (setup.py and stdlib), that is the leftover traces for MacOS9 support.
A simular patch needs to be created of the 3.x tree.
The reason I'd like a patch review is that it affects a lot of files and want a second pair of eyes to check that I haven't been too agressive.
The patch itself doesn't cause regressions in the unittests.
Hello
Some removals are unfinished, e.g.
→ remove the test and dedent the suite;
→ if platform != 'win32':
Regards
Removed traces of MacOS9 support in r80804 (trunk) and r80805 (3.2)
FTR, see also bpo-9508.
I’ve just noticed this problem:
--- a/Misc/BeOS-setup.py
+++ b/Misc/BeOS-setup.py
@@ -356,7 +356,7 @@ class PyBuildExt(build_ext):
libraries = dblib) )
# Unix-only modules
- if platform not in ['mac', 'win32']:
+ if platform == 'win32':
The logic is reversed. Shall I fix it in all affected branches?
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields: ```python assignee = 'https://github.com/ronaldoussoren' closed_at =
created_at =
labels = ['OS-mac', 'type-bug']
title = 'remove leftover macos9 support code'
updated_at =
user = 'https://github.com/ronaldoussoren'
```
bugs.python.org fields:
```python
activity =
actor = 'eric.araujo'
assignee = 'ronaldoussoren'
closed = True
closed_date =
closer = 'ronaldoussoren'
components = ['macOS']
creation =
creator = 'ronaldoussoren'
dependencies = []
files = ['16211']
hgrepos = []
issue_num = 7908
keywords = ['patch', 'needs review']
message_count = 6.0
messages = ['99209', '99227', '99384', '105076', '120584', '131492']
nosy_count = 2.0
nosy_names = ['ronaldoussoren', 'eric.araujo']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue7908'
versions = ['Python 2.7', 'Python 3.2']
```