python / cpython

The Python programming language
https://www.python.org
Other
63.38k stars 30.35k forks source link

Add math.tau #56554

Closed ncoghlan closed 8 years ago

ncoghlan commented 13 years ago
BPO 12345
Nosy @tim-one, @birkenfeld, @rhettinger, @pfalcon, @mdickinson, @ncoghlan, @abalkin, @vstinner, @benjaminp, @merwok, @asmeurer, @serhiy-storchaka, @vedgar, @Shredder13, @lisroach, @AraHaan
PRs
  • python/cpython#9755
  • Files
  • tau.diff
  • tau2.diff
  • tau3.diff
  • tau4.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = 'https://github.com/gvanrossum' closed_at = created_at = labels = ['easy', 'type-feature'] title = 'Add math.tau' updated_at = user = 'https://github.com/ncoghlan' ``` bugs.python.org fields: ```python activity = actor = 'danishprakash' assignee = 'gvanrossum' closed = True closed_date = closer = 'gvanrossum' components = [] creation = creator = 'ncoghlan' dependencies = [] files = ['44063', '44065', '44080', '44111'] hgrepos = [] issue_num = 12345 keywords = ['patch', 'easy'] message_count = 63.0 messages = ['138412', '138414', '138416', '138419', '138421', '138422', '138423', '138431', '138548', '138551', '138553', '139338', '183004', '183198', '272287', '272299', '272301', '272304', '272319', '272325', '272373', '272374', '272375', '272376', '272377', '272422', '272457', '272465', '272467', '272469', '272470', '272472', '272473', '272476', '272478', '272483', '272484', '272485', '272487', '272493', '272505', '272507', '272509', '272533', '272555', '272561', '272566', '272592', '272598', '272601', '272617', '272618', '272627', '272671', '272679', '272682', '272714', '272770', '272775', '272777', '272802', '313664', '313668'] nosy_count = 20.0 nosy_names = ['tim.peters', 'georg.brandl', 'rhettinger', 'pfalcon', 'mark.dickinson', 'ncoghlan', 'belopolsky', 'vstinner', 'benjamin.peterson', 'stutzbach', 'eric.araujo', 'Aaron.Meurer', 'python-dev', 'serhiy.storchaka', 'waldir', 'xcombelle', 'veky', 'Nofar Schnider', 'lisroach', 'Decorater'] pr_nums = ['9755'] priority = 'normal' resolution = 'fixed' stage = 'commit review' status = 'closed' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue12345' versions = ['Python 3.6'] ```

    ncoghlan commented 13 years ago

    I'd like to add a new constant to the math module:

      tau = 2*math.pi

    Rather than repeating all the reasons for why tau makes more sense than pi as the fundamental circle constant, I'll just refer interested readers to http://tauday.com/

    benjaminp commented 13 years ago

    Perhaps we should wait until \tau gains popularity larger than some impassioned physicist. \tau has been used to represent the golden ratio longer.

    rhettinger commented 13 years ago

    -1

    ncoghlan commented 13 years ago

    The golden ratio is more commonly denoted with phi (although tau does get used sometimes).

    Popularity isn't the point though, it's the fact that tau *makes geometric sense in ways that 2\pi doesn't.

    vstinner commented 13 years ago

    I like this issue number, but I don't think that Python needs this new constant: it's trivial to add it to your own project. We have pi and e, it's enough. If we begin to add a new constant, others will ask to add much more constants, and there are million of other constants (useful or not). You may want to create a library of some other common constants. You can use float.fromhex() to have a good accuracy.

    pitrou commented 13 years ago

    Nick, you just have to write: tau = 2 * math.pi and you're done.

    there are million of other constants

    Actually, I've heard there are an infinity of them.

    vstinner commented 13 years ago

    Actually, I've heard there are an infinity of them.

    Can you prove that?

    benjaminp commented 13 years ago

    2011/6/16 STINNER Victor \report@bugs.python.org\:

    STINNER Victor \victor.stinner@haypocalc.com\ added the comment:

    > Actually, I've heard there are an infinity of them.

    Can you prove that?

    Don't have to. Axiom of infinity. :)

    cfc9f3e0-e33f-4ecd-9ddd-4123842d6c1e commented 13 years ago

    On Wed, Jun 15, 2011 at 8:10 PM, Nick Coghlan \report@bugs.python.org\wrote:

    I'd like to add a new constant to the math module:

    tau = 2*math.pi

    Rather than repeating all the reasons for why tau makes more sense than pi as the fundamental circle constant, I'll just refer interested readers to http://tauday.com/

    (The following is best if read aloud using your best pirate impression)

    I'd rather name the new constant "matey". Then we have:

    The circumference of a circle is: r matey The area of a circle is: one-quarter r r matey etc.

    mdickinson commented 13 years ago

    Not to mention d(area of circle of radius r) = r dr matey.

    birkenfeld commented 13 years ago

    http://tauday.com/

    And I thought putting "dx" directly next to the integral sign was audacious...

    gvanrossum commented 13 years ago

    Uh, not until I've seen a lot more evidence that people are habitually writing "TAU = 2 * math.pi" in their programs...

    c9389d14-bb4a-4158-8809-cc110718bdf1 commented 11 years ago

    https://github.com/search?q=%22TAU+%3D+2+%2A+Math.PI%22&type=Code https://github.com/search?q=%22TAU+%3D+PI+*+2%22&type=Code

    93e6f677-8d67-42d7-b6f0-216497b0dfd2 commented 11 years ago

    Following-up sbaird's comment, I must point out that those aren't Python-specific results. Filtering them by appending &l=python to the urls yields:

    Then again, the results for all languages are still helpful to estimate the overall adoption of the notation in code, and indeed the global usage of these patterns (in github only) is in the hundreds.

    Also, it's worth taking a look at the usage of the twopi constant, which is already defined in several languages (http://en.wikipedia.org/w/index.php?oldid=509096802#Support_in_programming_languages), and has been manually defined in python quite often, proving its usefulness:

    gvanrossum commented 8 years ago

    I'm just going to do this.

    zware commented 8 years ago

    Builds fine on Windows. Happily, math.tau == 2*math.pi is True.

    gvanrossum commented 8 years ago

    OK, here's a diff with a test that math.tau ~~ 2*math.pi.

    tim-one commented 8 years ago

    Hmm. I'd test that tau is exactly equal to 2*pi. All Python platforms (past, present, and plausible future ones) have binary C doubles, so the only difference between pi and 2*pi _should_ be in the exponent (multiplication by 2 is exact). Else we screwed up one or both mantissas (typed the constant wrong, and/or the C compiler is rounding incorrectly) - which would be bad.

    mdickinson commented 8 years ago

    I'd test that tau is exactly equal to 2*pi.

    +1

    mdickinson commented 8 years ago

    At some point before 3.6, the docs should get updated, and cmath should get the tau constant too.

    rhettinger commented 8 years ago

    Perhaps minds are already made up, but this may be the last chance to say that I think that this shouldn't go forward.

    If needed, I can survey the audiences at the upcoming SF PyData conference and the SF PyBay conference to see if any of the participants have any clue what this is about and whether they would support the addition.

    serhiy-storchaka commented 8 years ago

    +1 to Raymond.

    gvanrossum commented 8 years ago

    Noted, but it doesn't change my decision. Obscure fact: did you know there are also branches of mathematics and engineering that define pi to for something else?

    pitrou commented 8 years ago

    Agreed with Raymond's arguments.

    5bdc2844-6f38-4b45-8218-144d190d3165 commented 8 years ago

    I also agree with Raymond's arguments. Adding tau doesn't add clarity to the math module, it just adds complexity.

    0126ad20-6e1d-4769-8afb-5e46d9da35a0 commented 8 years ago

    I agree with Raymond. In my opinion, it doesn't seem like there is a need to add such a constant. I know many of my previous and current colleagues would not use it (why should them if they can just write "2 * math.pi" ?) It seems that the efforts to spread the word that Pi is wrong and Tau is right haven't "bear fruits". For now I don't think we should make such a strong stand in adding it. If we do add new constants they should be of calculations that are harder and might ruin the code's visibility.

    https://www.explainxkcd.com/wiki/images/0/08/pi_vs_tau.png

    gvanrossum commented 8 years ago

    It's okay if Python occasionally shows its lighter side in unexpected places. Think of the delight of future (junior) high schoolers who discover that Python participates in the tau debate. :-)

    Also, I think this video by Vi Hart should be linked to from the docs for this constant: https://www.youtube.com/watch?v=jG7vhMMXagQ

    fe5a23f9-4d47-49f8-9fb5-d6fbad5d9e38 commented 8 years ago

    Guido once again shows he is not a mathematicians (honestly, most of the "arguments" for tau are plain nonsense), but he is a fantastic popularizer. I (and most of the other professional mathematicians) will love Python a tiny bit less, but a horde of people will love it more, and it's a fine tradeoff. :-)

    tim-one commented 8 years ago

    For those insisting that tau is somehow unnatural, just consider that the volume of a sphere with radius r is 2*tau/3*r**3 - the formula using pi instead is just plain impossible to remember ;-)

    pitrou commented 8 years ago

    Le 11/08/2016 20:07, Tim Peters a écrit :

    For those insisting that tau is somehow unnatural, just consider that the volume of a sphere with radius r is 2*tau/3*r**3 - the formula using pi instead is just plain impossible to remember ;-)

    Thank you, I'm totally convinced now :-)

    serhiy-storchaka commented 8 years ago

    In general, the volume, in n-dimensional Euclidean space, of the unit n-ball, is given by

        V_n = pi**(n/2) / gamma(n/2+1)

    or

        V_n = (tau/2)**(n/2) / gamma(n/2+1)
    pitrou commented 8 years ago

    The patch needs a documentation update, by the way.

    6fd3d553-ff50-40bd-a9a1-836658cb1a33 commented 8 years ago

    If this is implemented, it would be (as far as I can tell) the only thing in the math module that isn't also implemented in any of the standard external math libraries. None of numpy, scipy, sympy, or mpmath implement tau (if I'm missing one that others think is equally important to the ecosystem, let me know).

    6fd3d553-ff50-40bd-a9a1-836658cb1a33 commented 8 years ago

    I also wonder, if math will be gaining constants that no one uses like tau, if it will also gain constants that people actually do use (currently math just has pi, e, inf, and nan). [i for i in dir(numpy) if isinstance(getattr(numpy, i), float)] reveals euler_gamma as one example. https://docs.scipy.org/doc/scipy/reference/constants.html lists a bunch more.

    And if we're adding derived constants, why not loge2, another derived constants, used way more often than tau?

    In case you can't tell, I'm opposed to adding tau, although fwiw I do think it would be nice to add some of the other constants I mentioned above like euler_gamma to math, and in general, I support adding more stuff to math (but only generally useful stuff, obviously; there's no need to port all of scipy.special, for instance).

    As an aside, a technical note on the patch: for consistency, it should also be added to the cmath library (pardon me if I misread the patch and that's already happening).

    5531d0d8-2a9c-46ba-8b8b-ef76132a492c commented 8 years ago

    Aaron, I may be wrong, but I understood this to be something like:

    >>> from __future__ import barry_as_FLUFL
    >>> 3 <> 10
    True

    I *do* hope sympy supports that! :-)

    cd293b3e-6d38-412b-8370-a46a9aaee518 commented 8 years ago

    I think that whether or not something is trivial doesn't really correlate to whether or not it has its place in the language. After all, math.pi is 3.1416, and most people using pi will not worry about more than 4 decimal digits. Those who do are presumably using something better than floating-point arithmetic to begin with ;)

    For yet another colour to paint this tiny bikeshed, maybe we could put new constants in something like math.constants, with aliases to existing ones. Of course, I don't mean to point out how ridiculously disproportioned this discussion is, but...

    gvanrossum commented 8 years ago

    Let those other libraries follow.

    6fd3d553-ff50-40bd-a9a1-836658cb1a33 commented 8 years ago

    Emanuel Barry, that is both untrue and irrelevant (sorry to be blunt, but that's a total straw man on my and I believe other's argument). The fact that the only mathematical constants in math are pi and e (nan and inf aren't really "mathematical" constants) *does* indicate to me that only the really important ones are included.

    GvR, are you also in favor of adding more math constants/functions to the math module? I do see the value of Easter eggs in the language, but two real constants and one Easter egg constant seems weirder than ten real constants and one Easter egg constant. I'm +1/(2*pi) (because I still think tau in general is stupid) to add it if it also means the math module can be expanded. And before you ask, yes, I'll be happy to contribute once things move to GitHub.

    gvanrossum commented 8 years ago

    FWIW I don't plan to have more constants there, at the current rate we'll be fine for centuries. :-)

    What worries me more is proposals to add Python functions to math...

    --Guido (mobile)

    lisroach commented 8 years ago

    I've updated the test to assert tau is equal to 2*math.pi, as well as updated the docs and cmath.

    Let me know if I have made any errors!

    mdickinson commented 8 years ago

    The unification of tau2.diff and tau3.diff LGTM; thanks, Lisa!

    My commit bit is broken at the moment; anyone in a position to apply those patches?

    mdickinson commented 8 years ago

    BTW, if we're talking about useless constants in the math module, it's hard to get more useless than math.e: it's rare for e to turn up in formulas except in the form e**<something>, and the latter case is better catered for by the more accurate (and usually faster) expression exp(<something>. I'd even go so far as to call math.e worse than useless, since its presence leads people astray by encouraging them to write math.e**x instead of exp(x).

    To give just one example, on my machine, the result of exp(500) has an error of 0.42 ulps, while math.e**500 gives an error of over 150 ulps.

    serhiy-storchaka commented 8 years ago

    To give just one example, on my machine, the result of exp(500) has an error of 0.42 ulps, while math.e**500 gives an error of over 150 ulps.

    How can it be? math.e**500 = math.exp(math.log(math.e)*500) and math.log(math.e) is 1.0.

    vstinner commented 8 years ago

    math.e**500 = math.exp(math.log(math.e)*500)

    That's the theory if numbers have an infinite precision. In practice, intermediate results are rounded and have a limited precision.

    tim-one commented 8 years ago

    Serhiy's objection is a little subtler than that. The Python expression math.log(math.e) in fact yields exactly 1.0, so IF it were the case that x**y were implemented as

    math.exp(math.log(x) * y)

    THEN math.e**500 would be computed as math.exp(math.log(math.e) 500) == math.exp(1.0 500) == math.exp(500.0).

    But that's not how x**y is implemented. Because the error in log() is multiplied by y, and then fed into exp() blowing it up even more, only a hopelessly naive library would implement pow() that way. In practice, library pow functions fake the effect of at least 15 more bits than native double precision to absorb these errors.

    Under the covers, then, a reasonable library pow computes math.log(math.e) to more than native double precision - and _that_ (internal, invisible) result is not 1.0. Because math.e isn't the mathematical e to begin with. The difference between math.e and the mathematical e is a difference quite visible to the internal log, which delivers an internal log not equal to 1, and its difference from 1 is "an error" multiplied by 500 and fed into the internal exp (blowing up the error even more).

    In the end, math.e500 returns a very good approximation to the true value, given that math.e is not e. There's no reason to hope that's close to exp(500), though - that delivers a very good approximation to e500 (where e is the true e). The larger the exponent, the more different math.ey should be from exp(y), and for the same fundamental reason 2y differs from 3**y (or plug in any other pair of distinct bases).

    All that said, I agree with Mark that math.e is at best an attractive nuisance. Still, I'm -1 on removing it - it's a traditional and universally embraced nuisance ;-)

    02ad864c-ae2a-4ade-b93d-57afad65b191 commented 8 years ago

    What about rounding pi to 3 (and tau to 6)?

    https://en.wikipedia.org/wiki/Indiana_Pi_Bill (and I'm sure we can find a cute video about how cool to have pi as 3 to add it to the docs).

    abalkin commented 8 years ago

    All that said, I agree with Mark that math.e is at best an attractive nuisance.

    Why don't we fix the nuisance part without making it less attractive:

    class _E(float):
        def __pow__(self, other):
            if self is e:
                return exp(other)
            else:
                return pow(self, other)
    
    e = _E(2.718281828...)

    It's okay if Python occasionally shows its lighter side in unexpected places.

    I would rather see

    from math import π

    work in the future Pythons.

    I like Vi Hart, but I am firmly on the π side in the π vs. τ debate. The problem with τ is that it is visually smaller than π, actually twice smaller: π ≈ ττ, but the actual definition is the opposite.

    f99e2c47-6344-48ee-8423-2bbba951464a commented 8 years ago

    Python will really follow the tau sort joke ? I never saw it mentioned in any serious math or programming document. All the github search result looks like people who are in this joke (kind of).

    The page http://tauday.com/state-of-the-tau list very little use of tau in relevant domains, the most relevant to our discussion would be the including of tau in modula-2 standard library.

    I don't see how the introduction of the unknown tau constant in python programs will make them clearer or better to the targeted public who will read them.

    I must confess however that 2*pi occurs frequently in formula and these formula would be simplified if tau was used. However an honest and non partisan web site would list all the use of pi without 2 where the formula would be more complicated. I don't see that so I'm still not convinced.

    I know that Guido van Rossum is the Benevolent dictator for life of python, but as I understand it until this point, the dictator position was used after all argument took place and not before.

    fe5a23f9-4d47-49f8-9fb5-d6fbad5d9e38 commented 8 years ago

    However an honest and non partisan web site would list all the use of pi without 2 where the formula would be more complicated. I don't see that so I'm still not convinced.

    "non partisan" is probably hard to find, but if you want to see the other side of the story, http://www.thepimanifesto.com/ is probably most accessible.

    birkenfeld commented 8 years ago

    Please folks. Stop taking this so seriously and remember that this is the language where you can type in

    >> import antigravity

    and it actually works. (Sort of.)