python / cpython

The Python programming language
https://www.python.org
Other
62.14k stars 29.86k forks source link

Document how to forward POST data on redirects #58546

Open a5fd8934-dea1-4f2e-8be6-42f391104a7c opened 12 years ago

a5fd8934-dea1-4f2e-8be6-42f391104a7c commented 12 years ago
BPO 14338
Nosy @orsenthil, @merwok

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields: ```python assignee = None closed_at = None created_at = labels = ['easy', '3.8', '3.9', '3.10', 'type-feature', 'docs'] title = 'Document how to forward POST data on redirects' updated_at = user = 'https://bugs.python.org/beerNuts' ``` bugs.python.org fields: ```python activity = actor = 'iritkatriel' assignee = 'docs@python' closed = False closed_date = None closer = None components = ['Documentation'] creation = creator = 'beerNuts' dependencies = [] files = [] hgrepos = [] issue_num = 14338 keywords = ['easy (C)'] message_count = 3.0 messages = ['156080', '156108', '156346'] nosy_count = 5.0 nosy_names = ['orsenthil', 'eric.araujo', 'docs@python', 'crustymonkey', 'beerNuts'] pr_nums = [] priority = 'normal' resolution = None stage = 'needs patch' status = 'open' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue14338' versions = ['Python 3.8', 'Python 3.9', 'Python 3.10'] ```

Linked PRs

a5fd8934-dea1-4f2e-8be6-42f391104a7c commented 12 years ago

Issue bpo-14144, with the title "urllib2 HTTPRedirectHandler not forwarding POST data in redirect" was recently closed with these comments:

"This could be cookbook recipe style example, if it's utility value is high. I am closing this issue as I feel that the requirement may not be addressed by a change. If there is patch for HowTo, we can tackle that in another issue. Thank you for contribution."

The decision that documents on this issue were preferable to a patch seems like a fair compromise, especially considering that the RFC is decidedly ambiguous.I was wondering if the HowTo would be forthcoming? It seems to me that the value/utility would certainly be high. I'd submit it myself but I'm so new to Python that I don't trust my ability to do it correctly. It's something I would find highly useful, though.

merwok commented 12 years ago

The idea is to add a short example in Doc/howto/urllib2.rst. Senthil explained how to do things on bpo-14144 (“obtain the redirected URL and then POST to [it]”), and the example should be introduced by a clear warning about security/misbehavior risks (this is why I’m not adding the “easy” keyword to this report).

If you would like to propose a patch, you can find instructions on how to get and edit the source for the docs in the devguide. You can also write to the beginner-friendly core-mentorship mailing list (link in the devguide or on mail.python.org) to request help or guidance.

91ecfaa9-28b7-4925-affc-f3946a760fda commented 12 years ago

I actually just worked around this issue in my library to do specifically what I needed it to do, which was an automatic redirect POST with data. As far as general recipes are concerned, anyone could just follow what I did in my library at:

https://github.com/crustymonkey/py-sonic or http://pypi.python.org/pypi/py-sonic

All I did was just subclass HTTPRedirectHandler and essentially add my patch.