search

python / cpython

The Python programming language
https://www.python.org
Other
62.43k stars 29.97k forks source link

mingw: translate gcc internal defines to python platform specific defines #61790

Closed d8d5aad8-e55b-4500-a3a0-9ea982d771ff closed 2 years ago

d8d5aad8-e55b-4500-a3a0-9ea982d771ff commented 11 years ago
BPO 17590
Nosy @pfmoore, @tjguk, @vadmium, @zware, @zooba, @moreati
Superseder
  • bpo-45538: MinGW is unsupported - close all open issues and list them here.
    		•
    Files
  • 0002-MINGW-translate-gcc-internal-defines-to-python-platf.patch
  • MS_WINDOWS-move.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = created_at = labels = ['type-feature', 'OS-windows', 'build'] title = 'mingw: translate gcc internal defines to python platform specific defines' updated_at = user = 'https://bugs.python.org/rpetrov' ``` bugs.python.org fields: ```python activity = actor = 'iritkatriel' assignee = 'none' closed = True closed_date = closer = 'iritkatriel' components = ['Build', 'Windows'] creation = creator = 'rpetrov' dependencies = [] files = ['29624', '42141'] hgrepos = [] issue_num = 17590 keywords = ['patch'] message_count = 3.0 messages = ['185647', '261487', '261629'] nosy_count = 7.0 nosy_names = ['paul.moore', 'tim.golden', 'rpetrov', 'martin.panter', 'zach.ware', 'steve.dower', 'Alex.Willmer'] pr_nums = [] priority = 'normal' resolution = 'wont fix' stage = 'resolved' status = 'closed' superseder = '45538' type = 'enhancement' url = 'https://bugs.python.org/issue17590' versions = ['Python 3.4'] ```

    d8d5aad8-e55b-4500-a3a0-9ea982d771ff commented 11 years ago

    split of bpo-3871

    vadmium commented 8 years ago

    What’s the point of allowing each macro to already be defined? I understand they may also be defined by PC/pyconfig.h, but is that possible if __MINGW32__ is defined?

    Is the __MINGW32__ condition needed at all? Maybe we can just blindly rely on the _WIN32 etc macros. Perhaps the PC/pyconfig.h definitions could be removed in favour of the ones in "pyport.h"?

    vadmium commented 8 years ago

    Here is a possible alternative patch that moves MS_WINDOWS etc from PC/pyconfig.h to "pyport.h". Not tested with standard Windows build.