search

python / cpython

The Python programming language
https://www.python.org
Other
62.59k stars 30.04k forks source link

Code, test, and doc review for PEP-0435 Enum #62147

Closed ethanfurman closed 11 years ago

ethanfurman commented 11 years ago
BPO 17947
Nosy @gvanrossum, @warsaw, @ncoghlan, @vstinner, @benjaminp, @ezio-melotti, @alex, @ethanfurman, @zware, @phmc, @dstufft
Files
  • pep-0435.01.patch
  • pep-0435.02.patch
  • pep-0435.03.patch
  • pep-0435.04.patch
  • pep-0435.05.patch
  • pep-0435.06.patch: latest code with appropriate changes
  • pep-0435.07.eliben.patch
  • pep-0435.09.stoneleaf.patch
  • pep-0435.10.stoneleaf.patch
  • pep-0435.11.stoneleaf.patch
  • pep-0435.12.stoneleaf.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = 'https://github.com/ethanfurman' closed_at = created_at = labels = ['tests', 'type-feature', 'library', 'docs'] title = 'Code, test, and doc review for PEP-0435 Enum' updated_at = user = 'https://github.com/ethanfurman' ``` bugs.python.org fields: ```python activity = actor = 'ncoghlan' assignee = 'ethan.furman' closed = True closed_date = closer = 'python-dev' components = ['Documentation', 'Library (Lib)', 'Tests'] creation = creator = 'ethan.furman' dependencies = [] files = ['30192', '30195', '30202', '30209', '30231', '30265', '30384', '30506', '30511', '30512', '30548'] hgrepos = [] issue_num = 17947 keywords = ['patch'] message_count = 65.0 messages = ['188812', '188814', '188815', '188833', '188837', '188839', '188841', '188856', '188881', '188891', '188893', '188894', '188895', '188921', '188933', '188941', '188947', '188948', '188975', '188977', '188979', '188982', '189014', '189020', '189021', '189027', '189029', '189036', '189160', '189164', '189175', '189188', '189263', '189446', '190033', '190095', '190099', '190115', '190118', '190119', '190122', '190123', '190126', '190130', '190131', '190312', '190795', '190796', '190803', '190804', '190805', '190806', '190842', '190844', '190847', '190862', '190870', '190980', '191103', '191104', '191133', '191137', '191172', '191173', '191181'] nosy_count = 15.0 nosy_names = ['gvanrossum', 'barry', 'ncoghlan', 'vstinner', 'benjamin.peterson', 'ezio.melotti', 'alex', 'eli.bendersky', 'docs@python', 'ethan.furman', 'python-dev', 'zach.ware', 'pconnell', 'dstufft', 'isoschiz'] pr_nums = [] priority = 'normal' resolution = 'fixed' stage = 'resolved' status = 'closed' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue17947' versions = ['Python 3.4'] ```

    ethanfurman commented 11 years ago

    Good idea, thanks.

    786d3f11-b763-4414-a03f-abc264e0b72d commented 11 years ago

    I sent a fresh review - nothing major; it's very near commit readiness now. Additional changes can be done after the initial commit. We have time until 3.4 beta (November 2013) to tweak stuff (and the documentation whenever...)

    ethanfurman commented 11 years ago

    Doc updates are in.

    I removed the 'unique, constant' from the first line of the intro, as neither of those things are necessarily true.

    ethanfurman commented 11 years ago

    Hmm -- I was confusing member names with member values; I'll put 'unique' back in.

    ethanfurman commented 11 years ago

    Hopefully the last update. :)

    786d3f11-b763-4414-a03f-abc264e0b72d commented 11 years ago

    LGTM.

    I suggest you wait for a couple of days to see if others have any critical comments and then commit.

    zware commented 11 years ago

    enum.rst will need to be added to a table of contents page somewhere, I would guess possibly Development Tools (Doc/library/development.rst) or maybe Data Types (Doc/library/datatypes.rst). I would trust almost anybody else's opinion over mine on where it should go, though :)

    ethanfurman commented 11 years ago

    Final (hopefully! ;) patch.

    I stuck the toc reference in datatypes.

    If no more edits are necessary I'll commit on Friday (three days from now).

    1762cc99-3127-4a62-9baf-30c3d0f51ef7 commented 11 years ago

    New changeset fae92309c3be by Ethan Furman in branch 'default': Closes bpo-17947. Adds PEP-0435 (Enum, IntEnum) to the stdlib. http://hg.python.org/cpython/rev/fae92309c3be

    ncoghlan commented 11 years ago

    That commit looks just a touch incomplete...

    786d3f11-b763-4414-a03f-abc264e0b72d commented 11 years ago

    Ethan, did you forget to "hg add" ?

    On Fri, Jun 14, 2013 at 12:44 AM, Nick Coghlan \report@bugs.python.org\wrote:

    Nick Coghlan added the comment:

    That commit looks just a touch incomplete...

    ---------- resolution: fixed -> stage: committed/rejected -> commit review status: closed -> open

    Python tracker \report@bugs.python.org\ \http://bugs.python.org/issue17947\

    ethanfurman commented 11 years ago

    Well, that made me laugh first thing in the morning!

    I had nuked and redone my clone, and yeah, forgot to re-add the files. :/

    Trying again...

    Commit message was okay?

    1762cc99-3127-4a62-9baf-30c3d0f51ef7 commented 11 years ago

    New changeset e7a01c7f69fe by Ethan Furman in branch 'default': Closes bpo-17947. Adds PEP-0435 (Adding an Enum type to the Python standard library). http://hg.python.org/cpython/rev/e7a01c7f69fe

    vstinner commented 11 years ago

    New changeset e7a01c7f69fe by Ethan Furman in branch 'default': Closes bpo-17947. Adds PEP-0435 (Adding an Enum type to the Python standard library). http://hg.python.org/cpython/rev/e7a01c7f69fe

    Great job :-)

    ncoghlan commented 11 years ago

    Nicely done - you can also mark the PEP as Final now :)