Idle: Auto insertion of the closing parens, brackets, and braces

[7712ba6b-0e43-4aab-99de-5b1729b55566]

BPO	18875
Nosy	@terryjreedy, @mlouielu, @wohlganger
PRs	python/cpython#3520
Files	ParenClose.py: Extension to close parens, brackets, braces, ticks, and quotes ParenClose.py: version 0.2, added docstring, pep8 fixes test_parenclose.py: parenclose test ParenClose.py: version 0.4, made it easier to test, fixed problems found in testing test_parenclose.py: parenclose test 0.2 - pep8-ified, fixed minor bug

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields: ```python assignee = 'https://github.com/terryjreedy' closed_at = None created_at = labels = ['expert-IDLE', 'type-feature', '3.10'] title = 'Idle: Auto insertion of the closing parens, brackets, and braces' updated_at = user = 'https://bugs.python.org/THRlWiTi' ``` bugs.python.org fields: ```python activity = actor = 'terry.reedy' assignee = 'terry.reedy' closed = False closed_date = None closer = None components = ['IDLE'] creation = creator = 'THRlWiTi' dependencies = [] files = ['47021', '47023', '47029', '47030', '47031'] hgrepos = [] issue_num = 18875 keywords = ['patch'] message_count = 14.0 messages = ['196456', '196593', '220632', '220651', '220653', '220664', '228254', '298554', '298573', '298586', '298750', '302620', '315009', '374049'] nosy_count = 4.0 nosy_names = ['terry.reedy', 'THRlWiTi', 'louielu', 'wohlganger'] pr_nums = ['3520'] priority = 'normal' resolution = None stage = 'patch review' status = 'open' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue18875' versions = ['Python 3.10'] ```

[7712ba6b-0e43-4aab-99de-5b1729b55566]

Many other IDE's have this feature that allows automatic insertion of closing parentheses as user is typing something. I think it saves time and increases programming speed. Is it possible to have this on IDLE, too?

[terryjreedy]

I have thought about such a feature also. I would at least like to have patch to try it out. Possible? I suspect so.

[83d2e70e-e599-4a04-b820-3814bbdb9bef]

I'd like to see this feature as I've been using IDLE quite a lot recently and I'm so used to seeing it in other IDEs.

[terryjreedy]

I have never actually used this feature, and I do not see it in Notepad++. I worry that some people, especially beginners with no experience of this 'feature' would hate this, so it would have to be optional.

Do you literally mean 'parentheses' or also square and curly brackets? How about quotes? An autocloser here would be useful as Idle would not mishighlight the remainer of the text.

How does it increase speed? Hitting -> to skip over the closer is hardly faster that typing the closer. It might reduce errors though.

Tal, any opinion on this?

[taleinat]

I like the idea, though it's really just nice to have. This is a very common in IDEs these days, and whoever finds it annoying will be able to disable it.

If we do this, we should go all the way and close square and curly brackets, parenthesis, and quotes (including triple quotes!).

Also, any implementation must allow typing the closing parenthesis to actually just move the cursor beyond the automatically generated closer. Getting this right is more difficult than it sounds! But certainly possible.

I actually seem to recall having seen this implemented for IDLE quite a few years ago. I might even have been the one to implement it... I can't see any mention in IDLE-Spoon, IdleX or VIDLE, though. I'll take a look through my old files when I get the chance back home.

[taleinat]

Well, I was wrong. I can't find anything of the sort in my old IDLE files.

[terryjreedy]

This would have to be an extension, default off unless overridden, which is why I added config-extensions as dependency.

[b70526e6-c864-42a1-aa80-a1de956f683b]

I've written an extension (see file) that does auto insertion of closing parens, brackets, braces, ticks, and quotes. It also (optionally) skips the closers when they are typed right next to the already exiting one. It also takes into account triple-ticks / triple-quotes.

[9da18a29-a07d-4828-a801-24cc911246de]

Charles, good to saw the patch, would you like to convert it into GitHub PR? also, it would have to adjust some coding style to satisfy PEP-8. I can help you on GitHub to review this patch.

[b70526e6-c864-42a1-aa80-a1de956f683b]

I (foolishly) was committing to master for a different IDLE enhancement. Until that one is pulled, I don't think I can make a new PR without it also having all the changes from my previous one.

New uploaded file has docstrings for the ParenClose class and I've run and fixed it against PEP-8 until it gave no errors. Namespaces should conform to PEP-8, apart from the module name, which must match the class name due to how IDLE works with extensions.

[b70526e6-c864-42a1-aa80-a1de956f683b]

I've uploaded a test file and updated ParenClose.

[b70526e6-c864-42a1-aa80-a1de956f683b]

The PR contains all the requested features, as well as mutual deletion (requested on PR page), and I have separated out the options for mutual deletion triggered by delete or triggered by backspace. I've found in usage that it was irritating to have both, but nice to only have one. Let users pick one, both, or none.

[terryjreedy]

My question about the idea is whether beginners would use this, or if it is the sort of 'expert' feature that IDLE should avoid. I may ask on python-list for more opinions.

https://stackoverflow.com/questions/49677886/python-idle-symbol-completion/49684824#49684824 adds a vote in favor. It also prompted me to review the patch.

Since I said, 4 years ago, that the feature should be an extension, we have converted extensions to features. So the patch needs re-writing, as I outlined.

(Although there is now an extension configuration dialog, it is no longer a dependency of this issue.)

I am not convinced that we need 5 configuration options, especially since I do not understand 2 of them ;-). Do symbol and quote fences need to be separately enabled? Does anyone known what other IDEs do?

[terryjreedy]

I found this in Notepad++ under Settings -> Preferences -> Auto-completion -> Auto-insert with separate checkboxes for (, {, [, ', ", html/xml tags, and up to 3 custom pairs. Way too elaborate for IDLE. The only question to me is whether to have just one option for all 5 openers or separate option to complete ([{ versus quotes.

Concerns: a) matching triple quotes is a bit baroque, though possible the most useful part of the feature; b) except for completing tripple quotes, no keystrokes are saved, and then only if one used End to skip three chars at once. On the other hand, at least some people who have use the feature elsewhere consider it a net win.

Implementation notes: 1. IDLE editors uses two mechanisms to respond to keystrokes. The delegator mechanism checks all keystrokes and responds to some. IDLE otherwise binds keystrokes to event-handlers or to pseudoevent bound to event-handlers. Perhaps these could be unified and made more efficient.

2. In the meanwhile... Menu items are bound to pseudoevents, along with corresponding hot keys. This issue will *not* add a menu entry "Add matching closer". So the openers can be bound directly to event handlers that look at the opener.