search

python / cpython

The Python programming language
https://www.python.org
Other
63.38k stars 30.35k forks source link

Modernize HTML output of difflib.HtmlDiff.make_file() #67852

Open berkerpeksag opened 9 years ago

berkerpeksag commented 9 years ago
BPO 23664
Nosy @ezio-melotti, @berkerpeksag

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields: ```python assignee = 'https://github.com/berkerpeksag' closed_at = None created_at = labels = ['type-feature', 'library'] title = 'Modernize HTML output of difflib.HtmlDiff.make_file()' updated_at = user = 'https://github.com/berkerpeksag' ``` bugs.python.org fields: ```python activity = actor = 'ezio.melotti' assignee = 'berker.peksag' closed = False closed_date = None closer = None components = ['Library (Lib)'] creation = creator = 'berker.peksag' dependencies = [] files = [] hgrepos = [] issue_num = 23664 keywords = [] message_count = 1.0 messages = ['238106'] nosy_count = 2.0 nosy_names = ['ezio.melotti', 'berker.peksag'] pr_nums = [] priority = 'normal' resolution = None stage = 'needs patch' status = 'open' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue23664' versions = ['Python 3.6'] ```

berkerpeksag commented 9 years ago

This is a split off from bpo-2052. issue2052_html5_v2.diff (from bpo-2052) needs to be updated.

iritkatriel commented 2 years ago

@berkerpeksag Do you remember what this was about?

ezio-melotti commented 1 year ago

IIRC it refers to this piece of code https://github.com/python/cpython/blob/2781ec9b0e41a62cecc189c22dfc849f9a56927c/Lib/difflib.py#L1610-L1619 The generated documented uses XHTML 1.0 Transitional instead of HTML 5 and the template should therefore be updated (unless doing so break some tool that relies on it).

stefan6419846 commented 1 month ago

Does this cover the general outdated HTML syntax as well? At least in my case, PyCharm is complaining about the table output using the old cellspacing, cellpadding and rules attributes.