29d92137-f0d9-4d8f-8395-04e7d2566a1f
commented
8 years ago A piece of software stopped working after the update from Python 3.4.x to 3.5 (both Linux and Windows).
I found the cause in the Request.add_header("abcd","efgh") function: If the first parameter string "abcd" contains a colon (":") character, a ValueError is raised and the execution stops.
This is an example code:
>>> import urllib.request
>>> import urllib.parse
>>> data = urllib.parse.urlencode({'spam': 1, 'eggs': 2, 'bacon': 0})
>>> data = data.encode('utf-8')
>>> request = urllib.request.Request("http://requestb.in/xrbl82xr")
>>> # adding charset parameter to the Content-Type header.
>>> request.add_header("Content-Type:","application/x-www-form-urlencoded;charset=utf-8")
>>> with urllib.request.urlopen(request, data) as f:
... print(f.read().decode('utf-8'))
...This is the error:
Traceback (most recent call last):
File "C:\Users\user\Desktop\example.py", line 9, in <module>
with urllib.request.urlopen(request, data) as f:
File "C:\python\lib\urllib\request.py", line 162, in urlopen
return opener.open(url, data, timeout)
File "C:\python\lib\urllib\request.py", line 465, in open
response = self._open(req, data)
File "C:\python\lib\urllib\request.py", line 483, in _open
'_open', req)
File "C:\python\lib\urllib\request.py", line 443, in _call_chain
result = func(*args)
File "C:\python\lib\urllib\request.py", line 1268, in http_open
return self.do_open(http.client.HTTPConnection, req)
File "C:\python\lib\urllib\request.py", line 1240, in do_open
h.request(req.get_method(), req.selector, req.data, headers)
File "C:\python\lib\http\client.py", line 1083, in request
self._send_request(method, url, body, headers)
File "C:\python\lib\http\client.py", line 1123, in _send_request
self.putheader(hdr, value)
File "C:\python\lib\http\client.py", line 1050, in putheader
raise ValueError('Invalid header name %r' % (header,))
ValueError: Invalid header name b'Content-Type:'Steps to reproduce:
Add a colon character anywhere into the first parameter of the Request.add_header() function and execute the code using Python 3.5.x.
bitdancer
vadmium
berkerpeksag
1762cc99-3127-4a62-9baf-30c3d0f51ef7
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields: ```python assignee = None closed_at =
created_at =
labels = ['easy', 'type-feature', 'docs']
title = 'urllib.request > Request.add_header("abcd","efgh") fails with character ":" in first parameter string'
updated_at =
user = 'https://bugs.python.org/crickert'
```
bugs.python.org fields:
```python
activity =
actor = 'martin.panter'
assignee = 'docs@python'
closed = True
closed_date =
closer = 'martin.panter'
components = ['Documentation']
creation =
creator = 'crickert'
dependencies = []
files = ['40984']
hgrepos = []
issue_num = 25570
keywords = ['patch', 'easy']
message_count = 15.0
messages = ['254214', '254216', '254217', '254221', '254227', '254231', '254235', '254238', '254239', '254241', '254243', '254338', '254362', '266793', '266808']
nosy_count = 6.0
nosy_names = ['r.david.murray', 'docs@python', 'python-dev', 'berker.peksag', 'martin.panter', 'crickert']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25570'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']
```