search

python / cpython

The Python programming language
https://www.python.org
Other
63.54k stars 30.44k forks source link

test_poplib replace asyncore #74699

Open 6dc2ace7-63c1-4dd4-a1e8-050515409c65 opened 7 years ago

6dc2ace7-63c1-4dd4-a1e8-050515409c65 commented 7 years ago
BPO 30514
Nosy @vstinner, @grzgrzgrz3
PRs
  • python/cpython#1864
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = None created_at = labels = ['tests', '3.11'] title = 'test_poplib replace asyncore' updated_at = user = 'https://github.com/grzgrzgrz3' ``` bugs.python.org fields: ```python activity = actor = 'iritkatriel' assignee = 'none' closed = False closed_date = None closer = None components = ['Tests'] creation = creator = 'grzgrzgrz3' dependencies = [] files = [] hgrepos = [] issue_num = 30514 keywords = [] message_count = 2.0 messages = ['294770', '406378'] nosy_count = 2.0 nosy_names = ['vstinner', 'grzgrzgrz3'] pr_nums = ['1864'] priority = 'normal' resolution = None stage = None status = 'open' superseder = None type = None url = 'https://bugs.python.org/issue30514' versions = ['Python 3.11'] ```

    6dc2ace7-63c1-4dd4-a1e8-050515409c65 commented 7 years ago

    sub-issue of bpo-28533

    vstinner commented 3 years ago

    I removed asyncore in bpo-28533:

    New changeset 9bf2cbc4c498812e14f20d86acb61c53928a5a57 by Victor Stinner in branch 'main': bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521) https://github.com/python/cpython/commit/9bf2cbc4c498812e14f20d86acb61c53928a5a57

    But I kept a private copy as test.support._asyncore for the few tests which still use it (asyncore, asynchat and/or smtpd).

    hugovk commented 2 years ago

    Update: asyncore, asynchat, smtpd are still in 3.11 but set for removal in 3.12.

    See:

    AA-Turner commented 2 years ago

    @arhadthedev does this duplicate #93243?

    A

    arhadthedev commented 2 years ago

    @AA-Turner It seems so, but this issue already has a working PR. If @grzgrzgrz3 resolves the conflict there, I'd prefer to wait until it gets merged and to either close my PR or turn it into a rescurrection of gh-29521.