python / cpython

The Python programming language
https://www.python.org
Other
63.42k stars 30.37k forks source link

Typo in hamt.c comments #76924

Closed 81143e3b-245c-4d56-87b1-ea91e5e73d30 closed 6 years ago

81143e3b-245c-4d56-87b1-ea91e5e73d30 commented 6 years ago
BPO 32743
Nosy @1st1, @delimitry
PRs
  • python/cpython#5478
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = created_at = labels = ['3.8', 'type-feature', '3.7', 'docs'] title = 'Typo in hamt.c comments' updated_at = user = 'https://github.com/delimitry' ``` bugs.python.org fields: ```python activity = actor = 'delimitry' assignee = 'docs@python' closed = True closed_date = closer = 'delimitry' components = ['Documentation'] creation = creator = 'delimitry' dependencies = [] files = [] hgrepos = [] issue_num = 32743 keywords = ['patch'] message_count = 3.0 messages = ['311452', '311453', '311510'] nosy_count = 3.0 nosy_names = ['docs@python', 'yselivanov', 'delimitry'] pr_nums = ['5478'] priority = 'normal' resolution = 'fixed' stage = 'resolved' status = 'closed' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue32743' versions = ['Python 3.7', 'Python 3.8'] ```

    81143e3b-245c-4d56-87b1-ea91e5e73d30 commented 6 years ago

    In the comments to hamt_node_collision_without function in hamt.c module, I think should be so convert instead of co convert:

                 if (new_count == 1) {
                     /* The node has two keys, and after deletion the
                        new Collision node would have one.  Collision nodes
    -                   with one key shouldn't exist, co convert it to a
    +                   with one key shouldn't exist, so convert it to a
                        Bitmap node.
                     */
    1st1 commented 6 years ago

    Yeah, please submit a PR

    81143e3b-245c-4d56-87b1-ea91e5e73d30 commented 6 years ago

    Fixed