Typo reports on docs@

[zware]

BPO	34682
Nosy	@ericvsmith, @Wooble, @zware, @JulienPalard, @csabella, @miss-islington, @divyag9
PRs	python/cpython#13120 python/cpython#13279 python/cpython#13281

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields: ```python assignee = None closed_at = created_at = labels = ['easy', '3.8', 'type-feature', '3.7', 'docs'] title = 'Typo reports on docs@' updated_at = user = 'https://github.com/zware' ``` bugs.python.org fields: ```python activity = actor = 'cheryl.sabella' assignee = 'docs@python' closed = True closed_date = closer = 'cheryl.sabella' components = ['Documentation'] creation = creator = 'zach.ware' dependencies = [] files = [] hgrepos = [] issue_num = 34682 keywords = ['patch', 'easy'] message_count = 10.0 messages = ['325362', '325363', '325374', '325492', '326992', '341504', '341506', '342325', '342328', '342568'] nosy_count = 9.0 nosy_names = ['eric.smith', 'docs@python', 'geoffreyspear', 'zach.ware', 'mdk', 'cheryl.sabella', 'miss-islington', 'ZooDSS', 'divyag'] pr_nums = ['13120', '13279', '13281'] priority = 'normal' resolution = 'fixed' stage = 'resolved' status = 'closed' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue34682' versions = ['Python 3.7', 'Python 3.8'] ```

[zware]

From ZooDSS (Никита Люшненко) on docs@:

https://mail.python.org/pipermail/docs/2018-September/037223.html : """ https://docs.python.org/3/reference/datamodel.html#metaclass-example - "uses an collections.OrderedDict to remember" when it is better to use "uses a collections.OrderedDict to remember"

https://docs.python.org/3/reference/executionmodel.html#exceptions "Exceptions are a means" - Is it correct to use "a" here? "means" means a lot of them. "a" means one.

"In either case, it prints a stack backtrace" - most of the time in Python documentation term "traceback" is used instead of "backtrace". It may mislead newcomers, so they will think, that this is potentially a new term.

https://docs.python.org/3/reference/expressions.html#yield-expressions "Due to their side effects on the containing scope, yield expressions are not permitted as part of the implicitly defined scopes used to implement comprehensions and generator expressions (in Python 3.7, such expressions emit DeprecationWarning when compiled, in Python 3.8+ they will emit SyntaxError).." - two periods in the end of the sentence.

https://docs.python.org/3/reference/expressions.html#yield-expressions "...or automatically when the sub-iterator is a generator (by returning a value from the sub-generator)." - inconsistent use of "sub-iterator" term. Previously subiterator was referenced several times as "subiterator" not "sub-iterator".

If i understood something wrong, then i am sorry. """

https://mail.python.org/pipermail/docs/2018-September/037224.html : """ https://docs.python.org/3/reference/expressions.html#yield-expressions

Term "sub-generator" is used in PEP-280 without dash ("-") symbol - "subgenerator". At the same time it is used as "sub-generator" 2 times on this page:

"generator (by returning a value from the sub-generator)." - here.

"The proposal to introduce the yield_from syntax, making delegation to sub-generators easy." - and here. """

https://mail.python.org/pipermail/docs/2018-September/037237.html : """ https://docs.python.org/3/reference/expressions.html#asynchronous-generator-functions "function as a asynchronous generator function." - it's better to say "function as an asynchronous generator function."

https://docs.python.org/3/reference/expressions.html#agen.\_\_anext__ "When an asynchronous generator function is resumed with a __anext() method" - may be better "...function is resumed with an __anext() method".

"the awaitable instead raises an StopAsyncIteration exception" - at the same time here may be better to use "the awaitable instead raises a StopAsyncIteration exception".

https://docs.python.org/3/reference/expressions.html#agen.athrow "an StopAsyncIteration exception is raised" - here is the same situation as previously. "a" instead of "an" may be better.

Here goes very special case, and if i am wrong you can laugh on me as much as you wish! =)

https://docs.python.org/3/reference/expressions.html#parenthesized-forms "Since tuples are immutable, the rules for literals apply" - Tuples are immutable, but not literals. So may be "the same rules as for literals apply" is better? Or does it apply exactly those rules, that apply for literals? "()" - this is a literal, that yelds an empty tuple. But this doesn't connect, or i am wrong? If i am - then i am very sorry.

Again, if i mistook something - i am sorry. Thanks for the good work. This is the best documentation i've ever seen. """

[7935c1a3-fd0a-47d7-9c44-5b754e8ea743]

"Means" is perfectly acceptable to use as a singular form: http://grammarist.com/usage/means/ (the rest of these all look like legitimate typos)

[ericvsmith]

Agreed with @geoffreyspear: "means" is okay, the rest of the changes look good.

[93fa0b97-a0f6-4cfc-8a84-a81d9bfdcfed]

Wanted to add a little bit more, but didn't know where to, so here it goes.

https://docs.python.org/3/reference/expressions.html#membership-test-operations

"The operator not in is defined to have the inverse true value of in." may be better to use "... the inverse truth value of in." as it is used in the next section, for identity comparisons explanation:

"x is not y yields the inverse truth value."

https://docs.python.org/3/reference/expressions.html#is-not

In this section "object identity" is used two times. May be better to say "object's identity", as identity is a part of an object. Object has identity.

"...test for object identity" - here. "Object identity is determined..." - and here.

[93fa0b97-a0f6-4cfc-8a84-a81d9bfdcfed]

Found new one.

https://docs.python.org/3/reference/lexical_analysis.html#comments "Comments are ignored by the syntax; they are not tokens." - I honestly think, that this is misleading, by the fact that we have next words.

https://docs.python.org/3/library/token.html#token.COMMENT "Token value used to indicate a comment." - this means, that system mentions the comment as a token, but still ch.2 of LR says backwards. May be I am wrong. Correct me, please.

[csabella]

This is a good first issue even though there are multiple changes. Some of the changes are no longer needed since the docs have changed, so please check the current comments and the current docs to see what still needs to be applied.

[d18a6ce7-8b88-4a27-83a4-def6f2f00217]

I'll be working on this issue

[miss-islington]

New changeset 778a9107586e29421af3a08209cf0b557c1fe5bc by Miss Islington (bot) (divyag9) in branch 'master': bpo-34682: Wording and grammatical changes to the doc(https://docs.python.org/3) (GH-13120) https://github.com/python/cpython/commit/778a9107586e29421af3a08209cf0b557c1fe5bc

[JulienPalard]

New changeset 074d7c44a474680122ed869bb6be89c1f4f18f12 by Julien Palard (Stéphane Wirtel) in branch '3.7': [3.7] bpo-34682: Wording and grammatical changes to the doc(https://docs.python.org/3) (GH-13120) (GH-13281) https://github.com/python/cpython/commit/074d7c44a474680122ed869bb6be89c1f4f18f12

[csabella]

Thank you @divyag for the patch and thank you @matrixise for the backport!