python / cpython

The Python programming language
https://www.python.org
Other
63.38k stars 30.35k forks source link

stdlib - shutil.make_archive - add support for different ZIP compression method #80951

Open f31a8996-d448-4e36-8485-40dfb91f9705 opened 5 years ago

f31a8996-d448-4e36-8485-40dfb91f9705 commented 5 years ago
BPO 36770
Nosy @giampaolo, @tarekziade, @matrixise, @OwenChia
PRs
  • python/cpython#13447
  • Files
  • shutil.make_archive.patch: shutil.make_archive - add support for different ZIP compression method
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = None created_at = labels = ['3.8', 'type-feature', 'library'] title = 'stdlib - shutil.make_archive - add support for different ZIP compression method' updated_at = user = 'https://github.com/OwenChia' ``` bugs.python.org fields: ```python activity = actor = 'python-dev' assignee = 'none' closed = False closed_date = None closer = None components = ['Library (Lib)'] creation = creator = 'owenchia' dependencies = [] files = ['48293'] hgrepos = [] issue_num = 36770 keywords = ['patch'] message_count = 2.0 messages = ['341201', '342699'] nosy_count = 4.0 nosy_names = ['giampaolo.rodola', 'tarek', 'matrixise', 'owenchia'] pr_nums = ['13447'] priority = 'normal' resolution = None stage = 'patch review' status = 'open' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue36770' versions = ['Python 3.8'] ```

    f31a8996-d448-4e36-8485-40dfb91f9705 commented 5 years ago

    if you just want to use different zip compression method, no need to rewrite entire _make_zipfile function.

    e.g.
    >>> shutil.make_archive('archive', 'zip_lzma', '/path/to/whatever')
    matrixise commented 5 years ago

    Hi @OwenChia

    Thanks for your contribution!

    The project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

    CLA: https://www.python.org/psf/contrib/contrib-form/

    Could you create a PR on Github with your patch? In your bpo account, do not forget to assign your github account to your bpo account with the right value

    Thank you