python / cpython

The Python programming language
https://www.python.org
Other
63.19k stars 30.26k forks source link

Spelling error in unittest.mock code #82281

Closed lisroach closed 5 years ago

lisroach commented 5 years ago
BPO 38100
Nosy @matrixise, @lisroach, @miss-islington
PRs
  • python/cpython#16164
  • python/cpython#16165
  • python/cpython#16168
  • python/cpython#16191
  • python/cpython#16195
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = created_at = labels = ['easy', '3.8', '3.7', 'library', '3.9'] title = 'Spelling error in unittest.mock code' updated_at = user = 'https://github.com/lisroach' ``` bugs.python.org fields: ```python activity = actor = 'matrixise' assignee = 'none' closed = True closed_date = closer = 'matrixise' components = ['Library (Lib)'] creation = creator = 'lisroach' dependencies = [] files = [] hgrepos = [] issue_num = 38100 keywords = ['patch', 'easy', 'newcomer friendly'] message_count = 7.0 messages = ['351778', '352554', '352555', '352557', '352561', '352562', '352563'] nosy_count = 3.0 nosy_names = ['matrixise', 'lisroach', 'miss-islington'] pr_nums = ['16164', '16165', '16168', '16191', '16195'] priority = 'low' resolution = 'fixed' stage = 'resolved' status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue38100' versions = ['Python 3.7', 'Python 3.8', 'Python 3.9'] ```

    lisroach commented 5 years ago

    Good first issue.

    There is a spelling error in the unittest.mock library, "return_calulator" should be "return_calculator".

    This is in the _set_return_value method in [Lib/unittest/mock.py](https://github.com/python/cpython/blob/main/Lib/unittest/mock.py).

    lisroach commented 5 years ago

    It helps to comment on the issue before making a PR for it to claim it, as now we have 3 PRs all for the same issue :) We will likely accept the first PR that was created (or in this case the first PR that gets a CLA signed for it)

    matrixise commented 5 years ago

    New changeset a9187c31185fe7ea47271839898416400cc3d976 by Stéphane Wirtel (marcoramirezmx) in branch 'master': bpo-38100: Fix spelling error in unittest.mock code (GH-16168) https://github.com/python/cpython/commit/a9187c31185fe7ea47271839898416400cc3d976

    miss-islington commented 5 years ago

    New changeset cc8edfbd9c66a40e2d405e49b75227a8d2a4dd55 by Miss Islington (bot) in branch '3.8': bpo-38100: Fix spelling error in unittest.mock code (GH-16168) https://github.com/python/cpython/commit/cc8edfbd9c66a40e2d405e49b75227a8d2a4dd55

    matrixise commented 5 years ago

    Lisa, I don't close this issue because I would like to know if we have to back port to 3.7. The spelling error does exist into 3.7

    lisroach commented 5 years ago

    (y) Thanks for looking into it Stéphane!

    miss-islington commented 5 years ago

    New changeset 7aae4f004e69ebec011098f85ab232e2778a0ca4 by Miss Islington (bot) (Stéphane Wirtel) in branch '3.7': [3.7] bpo-38100: Fix spelling error in unittest.mock code (GH-16195) https://github.com/python/cpython/commit/7aae4f004e69ebec011098f85ab232e2778a0ca4