python / cpython

The Python programming language
https://www.python.org/
Other
61.16k stars 29.52k forks source link

Document that os.fork is not allowed in subinterpreters #82959

Closed 0f33552e-3426-4ce7-83ad-4a88a6ffc812 closed 4 years ago

0f33552e-3426-4ce7-83ad-4a88a6ffc812 commented 4 years ago
BPO 38778
Nosy @ericsnowcurrently, @phmc, @miss-islington
PRs
  • python/cpython#17123
  • python/cpython#17179
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = created_at = labels = ['3.8', '3.9', 'docs'] title = 'Document that os.fork is not allowed in subinterpreters' updated_at = user = 'https://github.com/phmc' ``` bugs.python.org fields: ```python activity = actor = 'eric.snow' assignee = 'docs@python' closed = True closed_date = closer = 'eric.snow' components = ['Documentation'] creation = creator = 'pconnell' dependencies = [] files = [] hgrepos = [] issue_num = 38778 keywords = ['patch'] message_count = 5.0 messages = ['356459', '356693', '356704', '356719', '356721'] nosy_count = 4.0 nosy_names = ['docs@python', 'eric.snow', 'pconnell', 'miss-islington'] pr_nums = ['17123', '17179'] priority = 'normal' resolution = 'fixed' stage = 'resolved' status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue38778' versions = ['Python 3.8', 'Python 3.9'] ```

    0f33552e-3426-4ce7-83ad-4a88a6ffc812 commented 4 years ago

    Add a comment to the os.fork docs to note that forking from a subinterpreter is no longer allowed (see bpo-34651)

    miss-islington commented 4 years ago

    New changeset b22030073b9327a3aeccb69507694bce078192aa by Miss Islington (bot) (Phil Connell) in branch 'master': bpo-38778: Document that os.fork is not allowed in subinterpreters (GH-17123) https://github.com/python/cpython/commit/b22030073b9327a3aeccb69507694bce078192aa

    ericsnowcurrently commented 4 years ago

    Nice work, Phil. We need a backport to 3.8, but the miss-islington bot is having trouble with it. [1] Either we can try flipping the "needs backport to 3.8" label again or you could create a backport PR yourself (like miss-islington suggested). If you do that then be sure to request a review from me. :)

    [1] https://github.com/python/cpython/pull/17123#issuecomment-554469177

    miss-islington commented 4 years ago

    New changeset a4be5aae6e587f5310f1fc0d66d37e032621ce39 by Miss Islington (bot) in branch '3.8': bpo-38778: Document that os.fork is not allowed in subinterpreters (GH-17123) https://github.com/python/cpython/commit/a4be5aae6e587f5310f1fc0d66d37e032621ce39

    ericsnowcurrently commented 4 years ago

    Flipping the label one more time did the trick. Thanks again, Phil!