python / cpython

The Python programming language
https://www.python.org
Other
63.38k stars 30.35k forks source link

HTTPConnection.timeout None support #83405

Open 9c76b4d6-1a41-4c54-a9d3-6bb7aab292ea opened 4 years ago

9c76b4d6-1a41-4c54-a9d3-6bb7aab292ea commented 4 years ago
BPO 39224
Nosy @dfarley1
PRs
  • python/cpython#17843
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = None created_at = labels = ['type-bug', 'docs'] title = 'HTTPConnection.timeout None support' updated_at = user = 'https://github.com/dfarley1' ``` bugs.python.org fields: ```python activity = actor = 'Daniel Farley' assignee = 'docs@python' closed = False closed_date = None closer = None components = ['Documentation'] creation = creator = 'Daniel Farley' dependencies = [] files = [] hgrepos = [] issue_num = 39224 keywords = ['patch'] message_count = 1.0 messages = ['359371'] nosy_count = 2.0 nosy_names = ['docs@python', 'Daniel Farley'] pr_nums = ['17843'] priority = 'normal' resolution = None stage = 'patch review' status = 'open' superseder = None type = 'behavior' url = 'https://bugs.python.org/issue39224' versions = [] ```

    9c76b4d6-1a41-4c54-a9d3-6bb7aab292ea commented 4 years ago

    HTTPConnection's timeout argument is passed down to socket.settimeout() which supports None and puts the socket in blocking mode. This isn't documented on the http.client page. Otherwise it should not be allowed.