encukou
commented
4 years ago One underlying issue from bpo-41631 is that importlib.util.LazyLoader produces modules that are only fully loaded after an attribute is accessed (through __getattribute__).
C-API functions like PyModule_GetState, PyModule_GetDict and such do not get attributes, and when called on a _LazyModule, they might try to access uninitialized C-level state.
I see two possible ways to fix this:
- Make PyModule_GetState, etc. trigger a full load. Since this is C-API, it would need a fast (no Python code) way either to do the full load or to detect _LazyModule.
- Make LazyLoader eager for either all extension & builtin modules, or for modules that have C-level storage. The latter would need a way to pass info from PyModuleDef to the loader.
Brett, does that analysis make sense from the importlib POV?
brettcannon
Lincoln-developer
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields: ```python assignee = None closed_at = None created_at =
labels = ['expert-C-API']
title = "PyModule_GetState doesn't work with LazyLoader"
updated_at =
user = 'https://github.com/encukou'
```
bugs.python.org fields:
```python
activity =
actor = 'corona10'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['C API']
creation =
creator = 'petr.viktorin'
dependencies = []
files = []
hgrepos = []
issue_num = 41797
keywords = []
message_count = 2.0
messages = ['376991', '377009']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'petr.viktorin', 'corona10', 'shihai1991']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue41797'
versions = []
```