search

python / cpython

The Python programming language
https://www.python.org
Other
62.39k stars 29.96k forks source link

http.server does not support HTTP range requests #86809

Open a28bdafa-f08b-4d5c-a058-5f14648d68ee opened 3 years ago

a28bdafa-f08b-4d5c-a058-5f14648d68ee commented 3 years ago
BPO 42643
Nosy @AraHaan, @sblondon, @DavidBord
PRs
  • python/cpython#24228
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = None created_at = labels = ['type-feature', 'library', '3.9', '3.10'] title = 'http.server does not support HTTP range requests' updated_at = user = 'https://github.com/AraHaan' ``` bugs.python.org fields: ```python activity = actor = 'DavidBord' assignee = 'none' closed = False closed_date = None closer = None components = ['Library (Lib)'] creation = creator = 'Decorater' dependencies = [] files = [] hgrepos = [] issue_num = 42643 keywords = ['patch'] message_count = 4.0 messages = ['383028', '383029', '383685', '387429'] nosy_count = 3.0 nosy_names = ['Decorater', 'sblondon', 'DavidBord'] pr_nums = ['24228'] priority = 'normal' resolution = None stage = 'patch review' status = 'open' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue42643' versions = ['Python 3.9', 'Python 3.10'] ```

    Linked PRs

    a28bdafa-f08b-4d5c-a058-5f14648d68ee commented 3 years ago

    I have issues with range requests on http.server module (ran from python -m http.server command)

    When requesting files to download from an program written in C (which uses range requests to update an progress bar) it ignores this and simply forces download of the entire thing at once) which in turn on my program makes the progress bar never update to display the progress of the download to the user.

    https://tools.ietf.org/id/draft-ietf-httpbis-p5-range-09.html#range.units

    It is a part from HTTP/1.1, I think this would be something good to actually have to support partial requests (if they request an range in the header of their request), for directory listings (which can be used to download files from), it could be considered helpful it be able to request specific byte ranges inside of the files to download at a time to split up bandwidth to not overwhelm an file server.

    a28bdafa-f08b-4d5c-a058-5f14648d68ee commented 3 years ago

    It seems there are some packages that supports the range requests too:

    https://github.com/danvk/RangeHTTPServer

    Not sure if that supports python 3 or not. It could be used to make a patch for http.server though.

    b786cac0-71df-4c35-a58b-012a049d8b3d commented 3 years ago

    RangeHTTPServer seems to support python3: there is a try-except clause to manage the different import of SimpleHTTPServer: https://github.com/danvk/RangeHTTPServer/blob/master/RangeHTTPServer/__main__.py#L13

    The code is under Apache 2.0 licence. I don't know if it can be integrated in codebase under the PSF licence.

    Another question needs to be answered previously: does the maintainers want to add such feature to SimpleHTTPServer (which goal is to be very basic)? They could prefer to add a header refusing the Range header: Accept-Ranges: none

    https://tools.ietf.org/id/draft-ietf-httpbis-p5-range-09.html#header.accept-ranges

    03eaabb4-13a9-47ec-862e-7e7aeaabd6ad commented 3 years ago

    I would appreciate a code review - thank you

    Le-Syl21 commented 1 year ago

    Hi,

    I've just install RangeHTTPServer to try but it's don't work as expected. it don't care about port anymore

    It don't use the new directory arguments from python3.

    The Range HTTP is need for PXE KickStart install https://access.redhat.com/solutions/1231383

    Redhat extract: If HTTP installation is used, confirm that the HTTP RANGE option is supported by the web server. Thehttpd package shipped by Red Hat supports it by default.

    I will try to fork this project to made a new one too make it work with improuvement...

    danvk commented 1 year ago

    I created RangeHTTPServer many years ago but can't remember the last time I used it. I'd be very happy if this functionality made it into SimpleHTTPServer and I could archive the repo.

    nil-ref commented 1 year ago

    I started a python -m http.server today. It took me a day to debug the program and found out that it doesn't understand range requests. I can't believe this problem was raised 3 years ago and it still hasn't been resolved.

    philpagel commented 1 year ago

    I'd also be very happy if range requests made it into the standard http.server. Use case: providing virtual images to HPE servers via iLO which requires range requests.

    rain-1 commented 1 year ago

    Is there interest in this?

    What work could be done to move this forward?

    lobis commented 11 months ago

    I would also be interested in this!

    lyc8503 commented 4 months ago

    The previous implementation of PR #24228 had some serious problems (reading a whole file into memory), and the handling of Range Not Satisfiable was inconsistent with the specification, and hadn't progressed for some time.

    So I've re-implemented PR #118949, solved the existing problems, and written more detailed test cases, hope someone can review it, thanks a lot!

    @imba-tjd I'm sorry mentioning you, but this issue is a bit old. I saw you review the previous PR, could you please review my new PR?