python / cpython

The Python programming language
https://www.python.org
Other
63.37k stars 30.33k forks source link

Some instructions in the "Using Python on Unix platforms" document do no work on CentOS 7 #89454

Closed 39c5c305-65db-4ea7-b061-3e01554df4d6 closed 3 years ago

39c5c305-65db-4ea7-b061-3e01554df4d6 commented 3 years ago
BPO 45291
Nosy @tiran, @ambv, @pablogsal, @miss-islington, @zhanpon
PRs
  • python/cpython#28566
  • python/cpython#28616
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = created_at = labels = ['3.11', 'type-feature', '3.10', 'docs'] title = 'Some instructions in the "Using Python on Unix platforms" document do no work on CentOS 7' updated_at = user = 'https://github.com/zhanpon' ``` bugs.python.org fields: ```python activity = actor = 'pablogsal' assignee = 'docs@python' closed = True closed_date = closer = 'christian.heimes' components = ['Documentation'] creation = creator = 'zhanpon' dependencies = [] files = [] hgrepos = [] issue_num = 45291 keywords = ['patch'] message_count = 7.0 messages = ['402657', '402846', '402851', '402852', '402916', '402932', '403154'] nosy_count = 6.0 nosy_names = ['christian.heimes', 'docs@python', 'lukasz.langa', 'pablogsal', 'miss-islington', 'zhanpon'] pr_nums = ['28566', '28616'] priority = 'normal' resolution = 'fixed' stage = 'resolved' status = 'closed' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue45291' versions = ['Python 3.10', 'Python 3.11'] ```

    39c5c305-65db-4ea7-b061-3e01554df4d6 commented 3 years ago

    The instructions in "Custom OpenSSL" section of "Using Python on Unix platforms" do not work on CentOS 7: https://github.com/python/cpython/blob/v3.10.0rc2/Doc/using/unix.rst#custom-openssl.

    CPython's ./configure script assumes the OpenSSL's library resides in "$ssldir/lib". This isn't guaranteed with the current instruction, because OpenSSL might create for example lib64 for the .so files. See https://github.com/openssl/openssl/blob/openssl-3.0.0/INSTALL.md#libdir:

    Some build targets have a multilib postfix set in the build configuration. For these targets the default libdir is lib\<multilib-postfix>. Please use --libdir=lib to override the libdir if adding the postfix is undesirable.

    Therefore it's better to explicitly set --libdir=lib.

    ambv commented 3 years ago

    New changeset bc4cde40339dd372960f27401d8fdaa4dab0f469 by zhanpon in branch 'main': bpo-45291: Explicitly set --libdir=lib when configure OpenSSL (GH-28566) https://github.com/python/cpython/commit/bc4cde40339dd372960f27401d8fdaa4dab0f469

    ambv commented 3 years ago

    New changeset 02fdd73a19464bafe9e5f98ecd17fd0a634c3f20 by Miss Islington (bot) in branch '3.10': bpo-45291: Explicitly set --libdir=lib when configure OpenSSL (GH-28566) (GH-28616) https://github.com/python/cpython/commit/02fdd73a19464bafe9e5f98ecd17fd0a634c3f20

    ambv commented 3 years ago

    Thanks, Yiyang Zhan! ✨ 🍰 ✨

    tiran commented 3 years ago

    Thanks!

    The documentation was not up to date for OpenSSL 3.0.0. The default for --libdir was changed late in the development cycle.

    39c5c305-65db-4ea7-b061-3e01554df4d6 commented 3 years ago

    Thank you for reviewing the pull request 😄

    pablogsal commented 3 years ago

    New changeset 63c4d42e6ea68104561c853b065c004b200eba68 by Pablo Galindo (Miss Islington (bot)) in branch '3.10': bpo-45291: Explicitly set --libdir=lib when configure OpenSSL (GH-28566) (GH-28616) https://github.com/python/cpython/commit/63c4d42e6ea68104561c853b065c004b200eba68