search

python / importlib_metadata

Library to access metadata for Python packages
https://importlib-metadata.readthedocs.io
Apache License 2.0
127 stars 82 forks source link

setuptools-scm is needed to install from source - [merged] #202

Closed jaraco closed 4 years ago

jaraco commented 4 years ago

In GitLab by @asottile on May 31, 2019, 17:16

Merges patch-1 -> master

jaraco commented 4 years ago

In GitLab by @codecov on May 31, 2019, 17:21

Codecov Report

Merging #74 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         191    191           
  Branches       18     18           
=====================================
  Hits          191    191

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7839d4...93c064b. Read the comment docs.

jaraco commented 4 years ago

In GitLab by @asottile on May 31, 2019, 17:22

This fixes installation when not using pep517 / pep518 installs (for instance on ~slightly older pip)

This tripped up a few packaging efforts I've seen so far:

jaraco commented 4 years ago

In GitLab by @asottile on May 31, 2019, 17:26

(what's worse is it successfully installs, but silently with garbage metadata):

$ pip install --no-binary :all: importlib-metadata
Collecting importlib-metadata
  Cache entry deserialization failed, entry ignored
  Cache entry deserialization failed, entry ignored
  Downloading https://files.pythonhosted.org/packages/0e/e0/9b28879fb8e2b7062279ef50b489a9e3b49d850df068d90571a4881905ee/importlib_metadata-0.17.tar.gz
Requirement already satisfied: zipp>=0.5 in ./venv/lib/python3.6/site-packages (from importlib-metadata)
Skipping bdist_wheel for importlib-metadata, due to binaries being disabled for it.
Installing collected packages: importlib-metadata
  Running setup.py install for importlib-metadata ... done
Successfully installed importlib-metadata-0.0.0
You are using pip version 9.0.3, however version 19.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

$ pip freeze -l
importlib-metadata==0.0.0
zipp==0.5.1
You are using pip version 9.0.3, however version 19.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
jaraco commented 4 years ago

In GitLab by @warsaw on May 31, 2019, 18:21

assigned to @warsaw

jaraco commented 4 years ago

In GitLab by @warsaw on May 31, 2019, 18:22

approved this merge request

jaraco commented 4 years ago

In GitLab by @warsaw on May 31, 2019, 18:22

merged

jaraco commented 4 years ago

In GitLab by @warsaw on May 31, 2019, 18:22

mentioned in commit ff02b7f5359db18072c0524f72225dc5fc765c3c