Closed jherland closed 1 year ago
Thanks for the review @FFY00. I took a look at the failing tests. The 3.12 failures seem related to #436, and the other three are cases of #434/#435.
Yep. I am just gonna wait a couple days to give Jason a bit more time to review, otherwise I'll just merge the fixes, unblocking this PR.
The first three commits fix #115 for the case where a
.egg-info
package includesinstalled-files.txt
: We preferinstalled-files.txt
overSOURCES.txt
as a source forDistribution.files
, as the former is deemed more accurate when it is available.The last two commits attempts to fix #115 for the case where we have no choice but to parse
SOURCES.txt
: This assumes thatDistribution.files
should never contain a path to a non-existent file. We simply remove non-existent files with a filter, thus removing any entries fromSOURCES.txt
that refer to files that were part of the source package, but not part of the final installation.Commits:
tests/fixtures
: FixFilesDef
type to includebytes
valuesDistribution.files
: Prefer*.egg-info/installed-files.txt
toSOURCES.txt
.files
from inaccurateSOURCES.txt
Distribution.files
: Only return files that actually exist