Miss-islington as a GitHub App

python / miss-islington

🐍🍒⛏🤖 - A bot for backporting and merging CPython pull requests

Apache License 2.0

107 stars 38 forks source link

Miss-islington as a GitHub App #659

Closed Mariatta closed 11 months ago

Mariatta commented 11 months ago

Use Installation Access Token instead of Personal Access token.

Note that the Personal Access Token is still needed during cherry-picking/backport process, as there is no GitHub API for cherry-picking.

Deployment tasks:

[x] Choose a name for the GitHub App.
[x] Create a GitHub App under the Python org
[x] Assign @Mariatta app manager role on app
[x] Set environment variables in miss-islington's Heroku app: GH_APP_ID, GH_PRIVATE_KEY (from the newly created GitHub App in the previous step)
[ ] Deploy and test

Mariatta commented 11 months ago

I still need to do some testing. Don't merge yet.

codecov[bot] commented 11 months ago

Codecov Report

Merging #659 (34186a6) into main (1f71458) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #659   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          356       357    +1     
  Branches        29        29           
=========================================
+ Hits           356       357    +1

Flag	Coverage Δ
Python_3.11	`100.00% <100.00%> (ø)`
Python_3.12	`100.00% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
miss_islington/backport_pr.py	`100.00% <100.00%> (ø)`
tests/test_backport_pr.py	`100.00% <ø> (ø)`

Mariatta commented 11 months ago

Tested on my personal repo and personal bot:

Original PR: https://github.com/Mariatta/cpython_for_test/pull/2

Backport PR created by app: https://github.com/Mariatta/cpython_for_test/pull/3

Mariatta commented 11 months ago

You can compare with how we did the conversion for bedevere: https://github.com/python/bedevere/pull/569

Mariatta commented 11 months ago

GitHub App settings:

webhook url: miss-islington's heroku url
webhook secret: miss-islington's GH_SECRET from before
enable SSL verification
logo: miss-islington's avatar

Permissions & events:

Contents: Read & write
Pull Requests: Read & write

Subscribe to events:

same events as the current miss-islington's webhook

Mariatta commented 11 months ago

During deployment, we realized additional things:

We needed to grant additional permission: "Checks"
We should have disabled miss-islington's webhook on CPython first.

After those are sorted out, things seem to work. Example activity by the app: https://github.com/python/cpython/pull/110090#issuecomment-1765072526