Open jacob-keller opened 5 months ago
Mypy's behavior is correct here. The typeshed definition for asyncio.gather
provides overloads for one to six arguments. You're passing seven arguments, so the behavior is dictated by a fallback overload:
def gather(*coros_or_futures: _FutureLike[_T], return_exceptions: Literal[False] = False) -> Future[list[_T]]: ...
Because mypy uses joins rather than unions, the resulting return type is Future[list[object]]
. (By contrast, pyright evaluates the return type as Future[list[str | datetime]]
).
To support seven or more arguments, the typeshed definition would need to be extended to include more overloads.
Right that makes sense. I suspect this used to work with an older version of typeshed at some point. I'll investigate there if it's worth fixing or if I can add my own overload to my project or something
Bug Report
mypy doesn't seem to properly infer types when unpacking the results of an asyncio.gather() that has at least 6 elements.
This leads to the unpacked variables getting assigned the object type, and then future uses of the variable cause typing issues.
To Reproduce
Expected Behavior
mypy should be able to infer the appropriate type of the values from the gathered list. From searching, it looks like this might be a typeshed issue, or it might be something in mypy itself. It is unclear what can be done here.
Actual Behavior
mypy infers the return of the await as a list, and then assigns the object type to each of the variables. This results in cascading type errors as other code assumes those variables would be the appropriate type.
If you only have 5 values, then this correctly unpacks the tuple into the specific variables. But as soon as you gather 6 items it breaks.
asyncio-gather-test.py:21: note: Revealed type is "tuple[builtins.str, builtins.str, builtins.str, datetime.datetime, builtins.str, builtins.str]" asyncio-gather-test.py:29: note: Revealed type is "builtins.str" asyncio-gather-test.py:30: note: Revealed type is "datetime.datetime"
Your Environment
mypy.ini
(and other config files): noneI'm really not sure what a good workaround in my own code would be here. For now I've taken to using asserts to check the types, which works ok, but is verbose.