Open jszopi opened 4 years ago
Something weird happens with the type variables. It doesn't look specific to tuples either:
from typing import Type, TypeVar, Generic, List
T = TypeVar("T")
CT = TypeVar("CT", bound="C")
DT = TypeVar("DT", bound="D")
class C(Generic[T]):
def __new__(cls: Type[CT], x: List[T]) -> CT:
...
class D(C[int]):
def __new__(cls: Type[DT]) -> DT:
result = C.__new__(cls, [1]) # OK
result = super().__new__(cls, [1]) # Error
return result
I wonder if we have some magic that can see the correspondence between CT
and T
in C.__new__
, but it fails for super()
.
In mypy 0.931 within Python 3.9 I can still reproduce the issue:
class MyNumbers(tuple[int, ...]):
def __new__(cls, a: int, b: int, *c: int) -> "MyNumbers":
iterables = a, b, *c
return super().__new__(cls, iterables)
# Argument 2 to "__new__" of "tuple" has incompatible type "Tuple[int, ...]"; expected "Iterable[_T_co]"
This persists in mypy 1.8.0; the reveal_type()
results are changed somewhat.
from typing import Tuple, Type, TypeVar
CoordsT = TypeVar('CoordsT', bound='Coords')
class Coords(Tuple[float, float, float]):
def __new__(cls: Type[CoordsT]) -> CoordsT:
reveal_type(super().__new__)
# Revealed type is:
# def [Self <: builtins.tuple[_T_co`1, ...]] (
# cls: Type[Self`190],
# typing.Iterable[_T_co`1] =
# ) -> Self`190
reveal_type(tuple.__new__)
# Revealed type is:
# def [_T_co, Self <: builtins.tuple[_T_co`1, ...]] (
# cls: Type[Self`191],
# typing.Iterable[_T_co`1] =
# ) -> Self`191
value = (0.0, 0.0, 0.0)
result = tuple.__new__(cls, value)
# fine
super().__new__(cls, value)
# error: Argument 2 to "__new__" of "tuple" has incompatible type
# "Tuple[float, float, float]"; expected "Iterable[_T_co]"
return result
Hi, when I inherit from
Tuple[float, float, float]
, and pass a tuple of floats as an argument tosuper().__new__
, I get an error saying that anIterable[_T_co]
was expected instead. As per thetypeshed
stub,_T_co
is supposed to be the type of the tuple elements, so I guess it's not getting deduced correctly. Further, this works withtuple.__new__
, so the involvement ofsuper()
must be to blame and the type signatures indeed aren't identical.I'm not sure if it's
mypy
ortypeshed
that is responsible for the function signature ofsuper
's__new__
, but I didn't find an overload for it intypeshed
, so I suspect this ismypy
's remitEdit: mypy 0.770, Python 3.7.3