new hg backups are failing

[ewdurbin]

From cron to infrastructure-staff:

Warning: Identity file /etc/backup/.ssh/id_rsa_hg-mercurial-static not accessible: No such file or directory. root@backup.sfo1.psf.io: Permission denied (publickey).

and

Warning: Identity file /etc/backup/.ssh/id_rsa_hg-svn-config not accessible: No such file or directory. root@backup.sfo1.psf.io: Permission denied (publickey).

It looks like this is because we infer that a given backup config has an individual backup key when templating the remote command.

[JacobCoffee]

Investigating... Keys are not being made for the two new entries :(

root@hg:~# ls /etc/backup/.ssh
id_rsa_python-hg

from

{{ backup }}-ssh-key:
  file.managed:
    - name: /etc/backup/.ssh/id_rsa_{{ backup }}
    - contents_pillar: backup-secret:directories:{{ backup }}:ssh_key
    - user: {{ config['user'] }}
    - mode: "0600"
    - show_diff: False 

probably due to missing pillar data in the secrets file for backup

[ewdurbin]

Resolved with #484