python / pyperformance

Python Performance Benchmark Suite
http://pyperformance.readthedocs.io/
MIT License
868 stars 175 forks source link

Only Try a Unique Venv If There Is a Conflict #157

Open ericsnowcurrently opened 2 years ago

ericsnowcurrently commented 2 years ago

Currently any failure when installing a benchmark's requirements triggers the creation of a unique venv for that benchmark and a retry of the install. The only failure for which we need to create a unique venv is when there is a conflict with the version of already installed packages. Adjusting the code along those lines would speed things up when their are failures (e.g. wheel cannot build) and produce less noise.

Possible solutions:

Also see https://github.com/python/pyperformance/issues/144#issuecomment-1075822776.

ericsnowcurrently commented 2 years ago

This is a follow-up to #155.