search

python / python-docs-theme

Sphinx theme for Python documentation
Other
76 stars 59 forks source link

Fix problem with monospace rendering in Vivaldi #104

Closed ZedThree closed 1 year ago

ZedThree commented 1 year ago

Fixes #98

cpython-cla-bot[bot] commented 1 year ago

All commit authors signed the Contributor License Agreement.
CLA signed

hugovk commented 1 year ago

Quoted "monospace" was added in https://github.com/python/python-docs-theme/pull/85 to workaround a Chrome bug, which was fixed in Chrome 96 (Nov 2021): https://github.com/python/pythondotorg/issues/1708#issuecomment-932596324.

By now, there's very little usage of Chrome 96 and older versions. Chrome 96% is 0.04% at https://caniuse.com/usage-table, and it's something like 1.68% for 96 and older.

(It would be good if we could hook up PR previews on Read the Docs or Netlify, that would make testing easier.)

ZedThree commented 1 year ago

I tested with Vivaldi 5.6.2867.62 and Firefox 109.0

hugovk commented 1 year ago

And I've put a preview build up at https://hugovk-cpython.readthedocs.io/en/python-docs-theme-pr-104/ if anyone else wants to test it.

Looks fine with Chrome 109 on Samsung S10 with Android 12.

hugovk commented 1 year ago

Thank you!