search

python / python-docs-theme

Sphinx theme for Python documentation
Other
75 stars 58 forks source link

New release? #109

Closed hugovk closed 1 year ago

hugovk commented 1 year ago

The last release was https://github.com/python/python-docs-theme/releases/tag/2022.1 in January 2022.

There's been a few bug fixes merged since then:

Notably:

My main motivation for a release is the dark theme: https://github.com/python/python-docs-theme/pull/44

I think it's ready for merge and release, but if we want to be safe, I suggest we make one release with the bugfixes, followed by another with the dark theme. That gives us the option to easily rollback in case there are any big issues.

cc @JulienPalard and @Mariatta :)

JulienPalard commented 1 year ago

Tag pushed, build one, testing one last time by building cpython doc with it locally...

$ cd cpython/Doc
$ make venv
$ ./venv/bin/pip install ../../python-docs-theme/dist/python_docs_theme-2023.3-py3-none-any.whl 
$ make htmlview

Looks good to me, uploading to pypi.

hugovk commented 1 year ago

Please could we have a new bugfix release with https://github.com/python/python-docs-theme/pull/113 to fix https://github.com/python/python-docs-theme/pull/108#issuecomment-1464879086?

It's causing docs build errors for 3.10 for example at https://github.com/python/cpython/pull/102638.

JulienPalard commented 1 year ago

Working on it!

JulienPalard commented 1 year ago

@hugovk done.

hugovk commented 1 year ago

I restarted https://github.com/python/cpython/actions/runs/4403319435 and it passed now.

Thank you!