search

python / python-docs-theme

Sphinx theme for Python documentation
Other
75 stars 58 forks source link

Dark theme: double magnifying glass on iOS #118

Open m-aciek opened 1 year ago

m-aciek commented 1 year ago

Big thank you for the work on dark theme (https://github.com/python/python-docs-theme/pull/44), I love the changes. I found minor bug while testing the updated styles on different devices.

On iOS, in both Chrome and Safari there's double magnifier glass shown near to the search box.

iOS 16.3.1, (Chrome 111.0.5563.72) cc @septatrix

septatrix commented 1 year ago

It is probably one of the following pseudo elements, if I were to guess probably the first:

input[type="search"]::-webkit-search-decoration
input[type="search"]::-webkit-search-cancel-button
input[type="search"]::-webkit-search-results-button
input[type="search"]::-webkit-search-results-decoration

It should be possible to hide it by applying a display: none; to the respective element. Or we could remove the search icon added by ourselves (how it is currently in the desktop search bar) and leave safari alone. Depends on what most people prefer.

m-aciek commented 1 year ago

My intuitional preference would be to just hide the browser-native icon to maintain the same interface across different machines.