python / python-docs-theme

Sphinx theme for Python documentation
Other
75 stars 58 forks source link

Remove searchbox ID from form #124

Closed septatrix closed 1 year ago

septatrix commented 1 year ago

Fixes #117.

The "Hide Search Matches" was not properly integrated into the layout, removing the ID reverts it to the previous behaviour where the toggle was suppressed.

Ideally we would have this working properly, however, sphinx sets this based on ID and we have more than one search forms so this would not show up properly (at the top and bottom of the desktop layout, and one in the mobile layout). With some CSS trickery it might be possible to reuse a single form element for the desktop and mobile layout such that this could be reasonably supported (and do without the toggle for the search form at the bottom) though this is a decent bit more complex and I am currently short on time.