Mobile menu not working - Githubissues

python / python-docs-theme

Sphinx theme for Python documentation

Other

74 stars 58 forks source link

Mobile menu not working #144

Closed hugovk closed 11 months ago

hugovk commented 1 year ago

Steps to reproduce:

Open docs in mobile view
Click the menu at the top left

Expected result: menu opens Actual result: menu doesn't open

Can repro with latest https://github.com/python/python-docs-theme/releases/tag/2023.7
Cannot repro with previous https://github.com/python/python-docs-theme/releases/tag/2023.3.1

This is due to the mobile-nav container being placed inside the document div instead of outside and before:

This is caused by https://github.com/python/python-docs-theme/pull/141 which moved mobile-nav, cc @miketheman.

hugovk commented 11 months ago

Fixed by reverting PR #141 in PR #146.

We'll need another fix for issue https://github.com/python/python-docs-theme/issues/130.