python / python-docs-theme

Sphinx theme for Python documentation
Other
74 stars 58 forks source link

Dark mode: fix contrast of footer highlight #162

Closed hugovk closed 8 months ago

hugovk commented 8 months ago

Fixes https://github.com/python/python-docs-theme/issues/161.

Before

image

After

image

No change to light mode

image

Preview

https://python-docs-theme-previews--162.org.readthedocs.build/en/162/library/gettext.html

ferdnyc commented 6 months ago

Hah! I was just coming here to get started on a similar pull request.

Unfortunately, while this is merged, it still isn't deployed on docs.python.org. Those docs still show the unreadable yellow background, in the dark theme.

Is there a procedure for getting the live docs to pull in theme updates?

hugovk commented 6 months ago

Hah! I was just coming here to get started on a similar pull request.

Thank you!

Is there a procedure for getting the live docs to pull in theme updates?

Yes, the procedure is:

We have a few thing pending release, I'll make one later today or this weekend.