search

python / python-docs-theme

Sphinx theme for Python documentation
Other
74 stars 58 forks source link

Remove incorrect CSS property #178

Closed Privat33r-dev closed 5 months ago

hugovk commented 5 months ago

Yes, we should fix this :)

But should we fix it by removing text-size, and not reducing the font size? So essentially maintain the status quo? I think I prefer the bigger ">>>" button:

Status quo: not setting font-size

image

https://python-docs-theme-previews.readthedocs.io/en/latest/tutorial/introduction.html#numbers

PR: font-size: 75%;

image

https://python-docs-theme-previews--178.org.readthedocs.build/en/178/tutorial/introduction.html#numbers

Privat33r-dev commented 5 months ago

From one point, it fixes the CSS, from the other point, it makes the element a bit small image image

As I was writing, you posted the same thing as well. I think that removal of the text-size property would be more desirable and if 2 people have the same idea independently, I guess that it's a valid point.

P.S. I as well did my life harder by forgetting to make a new branch. Also I will use rebase this time because I forgot to setup my name, email and signing key.

pradyunsg commented 5 months ago

@pradyunsg What do you think?

Good catch, and looks like this is good to merge! :)