search

python / python-docs-theme

Sphinx theme for Python documentation
Other
74 stars 58 forks source link

Footer: "Last updated on None" #182

Closed hugovk closed 4 months ago

hugovk commented 4 months ago

The typing docs use this theme:

https://typing.readthedocs.io/en/latest/

The footer says:

Last updated on None.

CPython docs has:

Last updated on Mar 23, 2024 (19:01 UTC).

Maybe typing is missing something in conf.py, or maybe this theme is making an assumption.

ezio-melotti commented 4 months ago

This? https://github.com/python/cpython/blob/eebea7e515462b503632ada74923ec3246599c9c/Doc/conf.py#L341-L342

hugovk commented 4 months ago

Yep, that looks like it.

The comment used to be:

# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.

https://github.com/python/cpython/commit/6c214dea7c503eb42bd130d43e8880f39bff0350

We should probably default to not showing the line if the config is missing, or use a default timestamp. Basically do whatever the earlier behaviour was.