search

python / pythondotorg

Source code for python.org
https://www.python.org
Apache License 2.0
1.5k stars 594 forks source link

Wrong arrow when select Comunity #1433

Open eamanu opened 5 years ago

eamanu commented 5 years ago

Describe the bug When click on Community button on the top menu the arrow select Python section

To Reproduce Steps to reproduce the behavior:

  1. Go to https://www.python.org/community/
  2. See on the top arrow. Python menu is selected.

Expected behavior Arrow select Community

Screenshots

image

Desktop (please complete the following information):

scottilee commented 5 years ago

I think the top nav button for "Community" should be removed.

The top nav buttons for "Python" and "PSF" introduce their own sub nav buttons where as the top bar button for "Community" is just same thing as the sub nav button "Community" found under top nav "Python".

scottilee commented 5 years ago

@ewdurbin What do you think? Would this need psf approval? If not I can make a pull request with the change.

Daniel-Davies commented 4 years ago

If this issue is still available I would love to make it my first contribution. Would this be possible?

eamanu commented 4 years ago

@Daniel-Davies Go aheah. @scottilee @ewdurbin any decision about Community nav button?

ewdurbin commented 4 years ago

These menus are configured as part of the django-sitetree module that renders them, so it's not super clear what the code solution would look like.

@Daniel-Davies if you're able to reproduce it locally and give directions on how to resolve it via configuring django-sitetree I can implement the change in Django admin.

Daniel-Davies commented 4 years ago

Ah I see- I won't be much help in that case, but I suppose after playing around with it and reproducing the issue, it looks like the sitetree item for the community tab (alias "shop-meta") has it's "is_current" property set to false, while mistakenly, the Python tab (alias "python-meta") is_current property is set to true.

I hope that's not too generic.

hugovk commented 2 weeks ago

Could this related to the fact the page is at https://www.python.org/community/ but the button links to https://www.python.org/community-landing/?

(And https://www.python.org/community-landing/ redirects to https://www.python.org/community/)

Also, @pradyunsg wrote in https://github.com/python/pythondotorg/issues/1894:

It seems like we're missing two things:

JacobCoffee commented 1 week ago

I think shop here is community, just named weird. In Django admin, it is set that way and is seen in the fixture data https://github.com/python/pythondotorg/blob/cbc6c143922933a082ad600207ddb75703757fe3/fixtures/sitetree_menus.json#L140

JacobCoffee commented 1 week ago

@hugovk I dont see this locally, fwiw

Could this related to the fact the page is at python.org/community but the button links to python.org/community-landing?