search

python / pythondotorg

Source code for python.org
https://www.python.org
Apache License 2.0
1.49k stars 592 forks source link

Sponsors brand logo doesn't show up when using an adblocker #2332

Open rilysh opened 9 months ago

rilysh commented 9 months ago

Describe the bug When using an adblocker (such as uBlock Origin), brand sponsors logo doesn't show up. After some digging into the filter list, I found that easylist blocks ethicalads.io domain (media.ethicalads.io) from where the logos are being pulled. Now I could just create an issue to easylist, but I'm certain that they don't want to just remove an advertising platform from their list.

To Reproduce Steps to reproduce the behavior:

  1. Install an ad-blocker (I used uBlock Origin)
  2. Go to https://www.python.org/psf/sponsors/
  3. See the results, and compare them by disabling the ad-blocker

Expected behavior I'm not sure why sponsors' logos need to be pulled from an advertising domain in the first place. They're just images and can be kept alongside the website. I'd expect images to be rendered without disabling the ad-blocker.

Screenshots With ad-blocker (uBlock) enabled: image

With ad-blocker (uBlock) disabled: image

Desktop (please complete the following information): N/A

Smartphone (please complete the following information): N/A

Additional Context I found a blog post (dated back to 2018) from ethicalads. I'm guessing that PSF has a partnership with ethicalads (I'm not sure), but again, I still don't get why images need to be pulled from a different domain in the first place.

ShaneCurcuru commented 7 months ago

Can confirm, happening to me with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:122.0) Gecko/20100101 Firefox/122.0 and uBlock Origin 1.55.0.

While I understand the appeal of using ethical ads to disintermediate when users view or interact with the python website versus sponsors, unfortunately this means a number of users see a slightly ugly sponsors page here.

I agree with rilysh that at least displaying the sponsor logos as static from your own site, or otherwise encoding the actual target URL for the sponsor somehow would be nice.

My use case is FOSS Foundations funding, where I'm researching sponsors across the FOSS ecosystem. To ensure reproducabilty (and for the chance to do historical analysis) I'm scraping sponsor webpages for hostnames in hrefs to map to sponsor companies. Since there's no link href here, I have to custom code a company name lookup.

In any case, thanks python peeps for all your work!