Closed vkurup closed 11 years ago
:shipit:
Nice work. The added tests LGTM. I'm not sure I completely follow the change here: https://github.com/python/raspberryio/commit/4e81430b349d11a74f8cdb8aff7bf9e75b3fa5d7 but I think you're right that the check is redundant.
IIRC, the search_models stuff is hard to unittest properly because of import time side-effects. This is entirely my own fault. I ran out of time making this work and didn't have time to troubleshoot making it bootstrap the search models properly without using gross side-effects. It is a definite code smell that would be nice to fix eventually but probably a bit out of scope for this.
If acceptable, I think this closes #115 for now.
/cc @calebsmith
Final result is: