search

python / release-tools

Scripts for making (C)Python releases
39 stars 33 forks source link

Test running "Build Python source and docs artifacts" workflow #134

Closed hugovk closed 4 months ago

hugovk commented 5 months ago

PR https://github.com/python/release-tools/pull/133 fixed a problem caused by PR https://github.com/python/release-tools/pull/130: Dependabot moved the --only-binary :all: option. I merged it because the CI passed. But the CI didn't actually run this workflow.

This PR adds triggers to run this for push/PR, in addition to the existing manual trigger (workflow_dispatch). In these cases, we don't have inputs (github.event.inputs), so set some default values instead.

We can skip running it when some test/lint files are changed, like .github/dependabot.yml and tests/ files.

Here's a sample PR trigger:

Here's a sample manual trigger:

hugovk commented 5 months ago

Interesting, I didn't get these shellcheck errors locally:

.github/workflows/source-and-docs-release.yml:98:9: shellcheck reported issue in this script: SC2086:info:2:31: Double quote to prevent globbing and word splitting [shellcheck]
hugovk commented 5 months ago

Ready for review.

Here's the latest manual trigger: https://github.com/hugovk/release-tools/actions/runs/9400901728