Closed hugovk closed 9 months ago
On the topic of updates, I normally use tags rather than commit hashes for actions.
And there's something a bit off about this one:
The comment says v5.0.0 but the first build says:
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
However, the v5.0.0 tag https://github.com/actions/setup-python/releases/tag/v5.0.0 (https://github.com/actions/setup-python/commit/0a5c61591373683505ea898e09a3ea4f39ef2b9c, Dec 6, 2023) does say Node.js was updated to v20.
And the 65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 commit is from Sep 7, 2023, before the upgrade.
Hmm, I used Frizbee to do the tag -> commit SHA locking. Now I'm confused if I messed up somehow or if there's an issue in that tool. Let me try reproducing that again.
I must have messed up somehow, Frizbee is resolving to uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
correctly now. You can update that inline in this PR.
Follow on from https://github.com/python/release-tools/pull/93.
Monthly, and grouped, to keep it less spammy.
Also add README with build badge.