search

python / the-knights-who-say-ni

CLA enforcement bot for Python organization projects
Apache License 2.0
85 stars 34 forks source link

PRs that need a CLA don't get resubmitted for checks #316

Closed PenelopeFudd closed 2 years ago

PenelopeFudd commented 2 years ago

I created a PR (https://github.com/python/cpython/pull/31319), but had not signed a CLA at that time.

I completed the CLA process, and the-knights-who-say-ni updated the PR status: image

At that point, one might have expected the PR checks to run, but they haven't yet and it's been 40 days.

image

As a workaround, I suppose I could resubmit my PR, but it looks like the process was designed to restart the checks when the CLA is signed.

Hopefully this will lower the barrier for other new contributors, making Python better for everyone!

AlexWaygood commented 2 years ago

This isn't anything to do with the-knights-who-say-ni, I'm afraid — this is a github feature that means that maintainers of an open-source project have to manually approve the CI workflow for first-time contributors. I believe that this is to prevent spammers (which you evidently are not) triggering the CI on PRs all the time.

JelleZijlstra commented 2 years ago

Yes, the CLA bot seems to be fine. I closed and reopened the PR to trigger the rest of CI.

PenelopeFudd commented 2 years ago

Ok, thanks!

I'd figured that "signing the CLA" was also being used as an anti-spamming mechanism which would trigger the rest of CI, but now I suspect that even with that, there's a sufficient volume of spammers getting through to warrant a two-step process. :-/

Ni! 😃