python / typing-council

Decisions by the Python Typing Council
43 stars 3 forks source link

Typing spec update: core concepts and definitions #31

Closed carljm closed 5 months ago

carljm commented 5 months ago

Hello! I'd like to request formal typing council consideration of https://github.com/python/typing/pull/1743, which adds to the typing spec a presentation of the core concepts of the Python type system, defines a number of key terms, and attempts to update the spec to use those terms consistently. The pull request has received excellent and thorough review from many members of the typing council and typing community.

I started a Discourse thread at https://discuss.python.org/t/formalizing-core-definitions-in-the-typing-spec/54785 -- it received a number of likes, but no replies.

TC sign off:

erictraut commented 5 months ago

@carljm, thanks again for driving this change! I thoroughly read an earlier draft and have been trying to follow all of the subsequent updates, but I'd like to read the final draft from top to bottom before signing off. It may be a few days before I have time to complete this review.

erictraut commented 5 months ago

I completed my top-to-bottom review. I left a few comments for very minor suggestions, but I'm fine if these are ignored or deferred to a subsequent PR. I've signed off on the change.

hauntsaninja commented 5 months ago

This is excellent, thank you for improving this!

(One minor process nit is that changes like this should probably be their own PR, even if uncontroversial)

carljm commented 5 months ago

Thanks all for the reviews! Per the documented process, I'll wait to merge the PR until a week has passed since I filed this issue.