python / typing-council

Decisions by the Python Typing Council
43 stars 3 forks source link

Typing spec update: PEP 712 `converter` in `dataclasses` Field spec params #33

Closed thejcannon closed 4 months ago

thejcannon commented 5 months ago

PR: https://github.com/python/typing/pull/1783 Discussion on PEP 712 (rejected adding to stdlib dataclasses, but community seemed in-favor of dataclass_transform addition).

This already is implemented in Pyright: https://github.com/microsoft/pyright/pull/5034

❤️ Thanks y'all!

TC sign-off

erictraut commented 5 months ago

@thejcannon, thanks for doing this. Could you please announce this PR in the discourse thread so the community has a chance to review it? We should then wait a week to see if any further comments come in.

erictraut commented 4 months ago

For reference, here's a link to the discourse thread.

thejcannon commented 4 months ago

For reference, here's the Typing council approval in Discourse: https://discuss.python.org/t/discuss-adding-converter-to-dataclass-transform/55125/5