python / typing

Python static typing home. Hosts the documentation and a user help forum.
https://typing.readthedocs.io/
Other
1.6k stars 237 forks source link

Class-qualified annotation expressions #1884

Open samwgoldman opened 3 days ago

samwgoldman commented 3 days ago

The wonderfully useful specification of type annotation expressions describes what kinds of expressions are valid type annotations.

I believe the spec does not include a case which type checkers support, although as we will see this comes down to semantics :)

class A:
    class B:
        pass

x: A.B = A.B()

The A.B annotation seems to fall under the name rule:

| name
      (where name must refer to a valid in-scope class,
       type alias, or TypeVar)

The spec helpfully continues:

Any leaf denoted as name may also be a qualified name (i.e., module '.' name or package '.' module '.' name, with any level of nesting).

The concept of a "qualified name" occurs only in this section, and the parenthetical explanation serves as it's most precise definition, as far as I can tell.

Should we extend the definition of "qualified name" to also include class members? Or maybe I should read the class as a "module" or a "package" and the existing definition suffices?

erictraut commented 3 days ago

Should we extend the definition of "qualified name" to also include class members?

Yes, I think that would be a good clarification. This section focuses primarily on the syntactic rules for type expressions and intentionally omits some of the detailed semantic rules because they are covered in more detail elsewhere in the spec. That said, I agree that there's room for additional clarity in the notes section here.

JelleZijlstra commented 3 days ago

Yes, this is a good point; I overlooked this possibility when I wrote that text.