python / typing_extensions

Backported and experimental type hints for Python
Other
446 stars 110 forks source link

Added support for Concatenate with Ellipsis #442

Closed Daraan closed 1 month ago

Daraan commented 3 months ago

Fixes #110.

This PR adds support for Ellipsis in Concatenate for the Python 3.8-3.10 backports.

Does not fix:

Changes:

cpython-cla-bot[bot] commented 3 months ago

All commit authors signed the Contributor License Agreement.
CLA signed

Daraan commented 1 month ago

I've made a rework (moved the parts to _create_concatenate_alias) that is now simpler and also works for Python 3.8 and fully solves #110 on the current version range.

AlexWaygood commented 1 month ago

Looks like you might have closed this accidentally. Probably this is something to do with the fact that it was a PR from your fork's main branch. I think it's unfortunately impossible to repair PRs when they get to this state — do you want to recreate the PR using a different branch on your fork? :-)

Daraan commented 1 month ago

Thanks for your kind reply. Yep I've just butchered this 🙈, I am sorry. It's as you assume related to the fork from main ...

AlexWaygood commented 1 month ago

We've all been there, pretty sure I've done it at least once :-)