Closed Daraan closed 1 month ago
I've made a rework (moved the parts to _create_concatenate_alias
) that is now simpler and also works for Python 3.8 and fully solves #110 on the current version range.
Looks like you might have closed this accidentally. Probably this is something to do with the fact that it was a PR from your fork's main
branch. I think it's unfortunately impossible to repair PRs when they get to this state — do you want to recreate the PR using a different branch on your fork? :-)
Thanks for your kind reply. Yep I've just butchered this 🙈, I am sorry. It's as you assume related to the fork from main
...
We've all been there, pretty sure I've done it at least once :-)
Fixes #110.
This PR adds support for Ellipsis in Concatenate for the Python 3.8-3.10 backports.
Does not fix:
48 : Using Ellipsis as argument for Callable with a generic..
typing.Callable
limitationstyping_extentions._ConcatenateGenericAlias
but also tricky.Changes:
_concatenate_getitem
to reflect the Python3.11 typing module that allows the Ellipsis parameter.typing._ConcatenateGenericAlias
and_concatenate_getitem
typing_extensions._ConcatenateGenericAlias
and_concatenate_getitem
like before