python3statement / python3statement.github.io

https://python3statement.github.io/
Other
110 stars 121 forks source link

add gluonnlp to the py3 pledge #250

Closed szha closed 5 years ago

szha commented 5 years ago

add gluonnlp to the py3 pledge

szha commented 5 years ago

ping @takluyver

nschloe commented 5 years ago

@szha Please don't tag me.

takluyver commented 5 years ago

I'm guessing from the URL that this is covered by the agreement for MXnet you already described in #251?

szha commented 5 years ago

@takluyver this is a separate community project and not part of the mxnet project.

takluyver commented 5 years ago

OK, and have any other maintainers of gluonnlp agreed about requiring Python 3 and about adding the project to the statement?

szha commented 5 years ago

Yes, see https://github.com/dmlc/gluon-nlp/issues/721

szha commented 5 years ago

@takluyver this PR should be ready now.

takluyver commented 5 years ago

Thanks. I was on holiday, that's why I wasn't merging things.

szha commented 5 years ago

@takluyver thanks! hope you had a good time