Closed soumith closed 5 years ago
Thanks, this all looks good. I'll give it a day or two for any pytorch maintainers to chime in. By that point I'll inevitably have forgotten, so ping me in a couple of days if there are no objections, and I'll merge it.
fyi, we've discussed it at https://github.com/pytorch/pytorch/issues/23795 and we're (pytorch maintainers) are all good on this.
But sure, I can ping you in a couple of days.
It looks like there hasn't been much discussion about signing the statement specifically: it's only suggested by @hugovk's post about a month ago, and then there are no responses until you mentioned this PR today.
It doesn't seem likely that anyone will object, but we've had at least one project that resolved to drop Python 2 support but not to sign this statement, so I take care not to merge any new signatures too quickly. :-)
(Obviously if I've overlooked some discussion about the statement, please correct me!)
pinging after two days :)
(Obviously if I've overlooked some discussion about the statement, please correct me!)
Yes, sorry the maintainers also discussed it on our private slack channel but that's not publicly visible info.
Thanks, and welcome aboard! :-)
If you're adding a project to the Python 3 statement, please ensure you have:
scripts/squash-images.sh
on it)