Django girls hack no longer needed

pythonanywhere / helper_scripts

Helper scripts provided to PythonAnywhere users (designed to be run from a PythonAnywhere console)

MIT License

33 stars 12 forks source link

Closed helenst closed 6 years ago

helenst commented 6 years ago

There's a hack in the DjangoProject class to install Django 1.x by default while Django Girls upgrades to 2.x. (https://github.com/pythonanywhere/helper_scripts/blob/master/pythonanywhere/django_project.py#L34) This has happened now - see https://github.com/DjangoGirls/tutorial/pull/1282 so the hack is not needed any more.

(This caught us out at a workshop today when we had an incorrectly named requirements.txt and ended up with 1.x in our venv)

hjwp commented 6 years ago

thanks Helen! taking a look...

hjwp commented 6 years ago

didn't know a requirement.txt is recommended now! that's cool...

pythonanywhere commented 6 years ago

OK, that's all deployed. I accidentally closed the issue -- I've re-opened it, would be grateful for any comments as to whether it all works OK :-)