search

pythonarcade / arcade

Easy to use Python library for creating 2D arcade games.
http://arcade.academy
Other
1.68k stars 319 forks source link

Review performance impact of `Sprite.scale` changes #2324

Open einarf opened 1 month ago

einarf commented 1 month ago

This might just be about reverting https://github.com/pythonarcade/arcade/pull/2021

The vector sprite perf testing showed 2.x cost. We should quickly review the cost of the sprite scale changes before we release.

https://github.com/pythonarcade/arcade/blob/fa6e9387cb9801081f378a4b4e978028ea531bd8/arcade/sprite/base.py#L263-L339

We might just have to revert these changes for now and bake them into the new experimental sprites. See : https://github.com/pythonarcade/arcade/issues/2184

einarf commented 1 month ago

Considering scale returns a Vec2 this should be part of the vector sprites later in 3.1/3.2