pythonarcade / arcade

Easy to use Python library for creating 2D arcade games.
http://arcade.academy
Other
1.71k stars 330 forks source link

Fix: issue-2429-Add_direction_to_ScreenShake2D #2446

Closed ouad002 closed 1 week ago

ouad002 commented 1 week ago

The fix addresses an enhancement request for the ScreenShake2D class in the Arcade library by introducing an optional direction_deg parameter. This allows users to specify a constant direction for the screen shake effect, expressed in degrees. If the direction_deg parameter is not provided, the shake continues to occur randomly, as before. The fix ensures that when direction_deg is set, the shake occurs along a fixed angle, providing more control over the shake's direction while maintaining the original random behavior when the parameter is not used.

DragonMoffon commented 1 week ago

The fact that this removes important methods, the double definitions of the stop function, the strange rewriting of docs, and the lack of style following makes me suspicious that this was, at least in part, written by generative AI. We appreciate every PR made into Arcade. However, this PR needs heavy revision before I can accept it.

DragonMoffon commented 1 week ago

Closing in favor of #2448