pythonarcade / arcade

Easy to use Python library for creating 2D arcade games.
http://arcade.academy
Other
1.71k stars 330 forks source link

modified (point_in_view) function #2453

Closed Maphineth-UNG closed 1 week ago

Maphineth-UNG commented 1 week ago

I modified the point_in_view method to improve its clarity and readability. Currently, it calculates the dot product manually and uses intermediate variables. We can simplify it using vectorized operations to make it more concise and efficient.

Explanation:

DragonMoffon commented 1 week ago

This PR has been closed as it makes no functional or performance improvements to the point_in_view method. It also reads like it was written using LLM. While we appreciate all PR's made into Arcade, we require them to be authored and written by people.

einarf commented 1 week ago

Also: The existing method is optimized. Introducing Vec2 will make it 10x slower. "High performance" in python is a completely different beast and needs careful human crafting.